Skip to content

Comments

perf: upgrade AG Grid v34 → v35#557

Closed
paddymul wants to merge 1 commit intoperf/ag-grid-v34from
perf/ag-grid-v35-final
Closed

perf: upgrade AG Grid v34 → v35#557
paddymul wants to merge 1 commit intoperf/ag-grid-v34from
perf/ag-grid-v35-final

Conversation

@paddymul
Copy link
Collaborator

Summary

  • Bump AG Grid v34 → v35
  • Add suppressNoRowsOverlay: true to infinite row model grid options (v35 adds default overlays that flash during data loading)
  • ESM bundle: 1,773 KB → 1,827 KB (+3% code growth)

Test plan

  • tsc -b — 0 errors
  • pnpm test — 67/67 pass
  • vite build — success
  • CI checks pass

🤖 Generated with Claude Code

@paddymul paddymul force-pushed the perf/ag-grid-v35-final branch 2 times, most recently from 5b09ee9 to c4ac1fd Compare February 24, 2026 04:03
@github-actions
Copy link

github-actions bot commented Feb 24, 2026

📦 TestPyPI package published

pip install --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo==0.12.9.dev22336319012

or with uv:

uv pip install --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo==0.12.9.dev22336319012

MCP server for Claude Code

claude mcp add buckaroo-table -- uvx --from "buckaroo[mcp]==0.12.9.dev22336319012" --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo-table

Add suppressNoRowsOverlay to infinite row model grid options
(v35 adds default overlays that flash during data loading).
ESM bundle: 1,773 KB → 1,827 KB (+3%)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@paddymul
Copy link
Collaborator Author

Closing — v35 not needed

v33 gives us the best bundle size (-31% wheel, -61% widget.js). v35 adds ~6% back over v33 with only one relevant change:

  • Infinite row model overlays — v35 adds automatic "No rows" / "No matching rows" overlays. We'd need suppressNoRowsOverlay: true to handle this. Not worth the size increase just to suppress a new default.
  • Formulas, column selection, absolute sorting, BigInt, formula editor — none relevant to a dataframe viewer

No performance improvements for infinite scroll, pinned rows, or cell rendering.

Policy: don't bump AG Grid until we need a specific feature. Can always revisit if something in v35+ becomes relevant.

@paddymul paddymul closed this Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant