ci: remove redundant pnpm/node setup from Playwright test jobs#543
Open
ci: remove redundant pnpm/node setup from Playwright test jobs#543
Conversation
📦 TestPyPI package publishedpip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo==0.12.8.dev22284791530or with uv: uv pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo==0.12.8.dev22284791530 |
The test scripts already run their own `pnpm install` in packages/buckaroo-js-core/. The CI-level workspace-wide `pnpm install --frozen-lockfile` was redundant. pnpm setup and cache are kept so the scripts' install is fast. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
paddymul
force-pushed
the
ci/simplify-playwright-deps
branch
from
1ef327d to
7b2fa9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm install --frozen-lockfilefrom TestMarimo, TestWASMMarimo, and TestJupyterLab jobsactions/setup-node(Playwright needs Node.js)pnpm install/npm installinpackages/buckaroo-js-core/, so the CI-level workspace install was redundantWhy these jobs still need Node.js
Playwright is a Node.js tool — the test scripts run
npx playwright test/pnpm exec playwright test. Node.js is a hard requirement. But the full pnpm workspace setup was unnecessary since each script installs only the deps it needs.Test plan
🤖 Generated with Claude Code