fix(nestjs-crud): skip CrudContextOverlay on non-CRUD controllers#461
Open
tnramalho wants to merge 1 commit intobtwld:feature/version-8from
Open
fix(nestjs-crud): skip CrudContextOverlay on non-CRUD controllers#461tnramalho wants to merge 1 commit intobtwld:feature/version-8from
tnramalho wants to merge 1 commit intobtwld:feature/version-8from
Conversation
The CrudContextOverlay is registered as a global APP_INTERCEPTOR by CrudModule.forRoot(). It was throwing CRUD_CONTEXT_ERROR on any controller that does not have CRUD metadata (@CrudController or @CrudEntity), making it impossible to have normal REST controllers coexist with CRUD-generated controllers in the same application. The fix checks for CRUD entity metadata on the controller before attempting to resolve the CRUD context. If the controller has no entity metadata, the interceptor skips silently. Added e2e tests that register a plain @controller alongside CrudModule.forRoot({}) and verify it responds 200 without errors. Also fixed pre-existing markdown lint errors in nestjs-crud, nestjs-invitation, and nestjs-repository README files. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
To view this pull requests documentation preview, visit the following URL: docs.page/btwld/nestjs-modules~461 Documentation is deployed and generated using docs.page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CRUD_CONTEXT_ERRORon any controller without CRUD metadataTest plan
@ControllerwithCrudModule.forRoot({})— verifies 200 response without errors/me(MeController) now works alongside CRUD-generated/petscontroller🤖 Generated with Claude Code