Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ grow it.
## Prerequisites

- **Node** `>=22.19`
- **pnpm** `11.7.0` (pinned via `packageManager`; run `corepack enable` to get it)
- **pnpm** `12.4.1` (pinned via `packageManager`; run `corepack enable` to get it)
Comment thread
coderabbitai[bot] marked this conversation as resolved.

## Getting started

Expand Down Expand Up @@ -118,12 +118,10 @@ Three numbers, and they mean different things:
CI runs the test job on `["", "22.19", "24", "26"]` — the pinned version, the
repo's own development floor, and the two current release lines.

**The published package's floor is not covered, and this matrix cannot cover
it.** These jobs run the development toolchain, and pnpm 11 requires
`node:sqlite`, so a Node 20 row dies at `setup-node` before installing
anything: `ERR_UNKNOWN_BUILTIN_MODULE: No such built-in module: node:sqlite`.
That would test the toolchain, not the package — and it contradicts the root
`engines` above, which already says development needs `>=22.19`.
**The published package's floor is not covered by this matrix.** These jobs
run the development toolchain, so a Node 20 row would test the toolchain, not
the package — and it contradicts the root `engines` above, which already says
development needs `>=22.19`.

`engines` on `packages/entity` is a claim about **consumers**, who install the
published tarball with their own package manager and import it. Proving it
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@
"engines": {
"node": ">=22.19"
},
"packageManager": "pnpm@11.7.0"
"packageManager": "pnpm@12.4.1"
}
158 changes: 158 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading