chore: drop review labels, unused tmux helpers, stale Go version - #30
Merged
Merged
Conversation
- Replace the C1/I1/I3/M1 review labels in editor_state.go and its tests with plain explanations. The labels pointed at a review that isn't in the repo. - Remove Client.BaseIndex and Client.NewWindowInSession. Nothing calls them, and the unused linter skips exported methods. - CONTRIBUTING.md now points at go.mod for the Go version instead of naming 1.24 (the module and CI are on 1.25).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup with no behavior change.
editor_state.goand its tests carried C1/I1/I3/M1 labels from a review that isn't in the repo. Replaced them with plain explanations of what each guard or test protects.Client.BaseIndexandClient.NewWindowInSession. Nothing calls them, and theunusedlinter skips exported methods, so they never got flagged.CONTRIBUTING.mdsaid Go 1.24. The module and CI are on 1.25, so it now points atgo.modinstead of naming a version.go test -race ./...and golangci-lint v2.12.2 are clean.