fix: generate RFC-compliant TOTP codes - #410
Open
giri256 wants to merge 1 commit into
Open
Conversation
Signed-off-by: p1 <giridharpavan593@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #358
otplib11 transforms TOTP secrets to the digest length before HMAC. For short seeds that repeats the decoded bytes, which produces a different key and therefore a different OTP than other RFC-compatible implementations.This overrides the library's documented
createHmacSecrethook so HMAC receives the decoded secret bytes unchanged and performs its normal RFC 2104 key handling.I also added regression vectors for short SHA-1, SHA-256, and SHA-512 secrets, plus the standard 20-byte SHA-1 vector.
Verification:
yarn testprettier --check package.json helpers/base.test.jsbackground.js