Conversation
Assisted-by: Replit
🦋 Changeset detectedLatest commit: 807a930 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
This PR is from an external contributor and must be approved by a stagehand team member with write access before CI can run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
Long-running Stagehand RPCs need two forms of caller control:
Cancellation must not implicitly close Stagehand or the underlying browser. A later operation should still be able to use the existing session.
what changed
rpcTimeoutstoStagehand.create():defaultMssets a response deadline for ordinary RPC calls.methodsoverrides the default for specific Stagehand RPC methods.2_147_473_647ms.getCallOptions()toStagehand.create():{ signal?: AbortSignal }.stagehand.initandstagehand.callback_batchoutside both hooks:experimentalBatch()retains its existing whole-batch timeout and cancellation behavior.test plan
pnpm --filter @browserbasehq/stagehand typecheckpnpm --filter @browserbasehq/stagehand buildpublint.pnpm --filter @browserbasehq/stagehand test:unitFocused coverage verifies:
getCallOptions()is called once per ordinary RPC;Summary by cubic
Adds configurable response wait deadlines and per-call abort signals to ordinary Stagehand RPC calls, so callers can bound how long they wait and cancel a single call without closing the session.
Stagehand.create()accepts two new TypeScript-only options:rpcTimeouts(defaultMswith per-method overrides) andgetCallOptions()returning an optionalAbortSignal.2_147_473_647ms.getCallOptions()is invoked once before each ordinary RPC call, and a pre-aborted signal fails before the call is sent.stagehand.initandexperimentalBatch()ignore both hooks and keep their existing lifecycle timeout and cancellation behavior.Written for commit 807a930. Summary will update on new commits.