Sandbox Contributions part 1#8
Open
ironm00n wants to merge 7 commits into
Open
Conversation
Adds a test checking that Pyret correctly threw an error. Co-authored-by: Bobby Palazzi <bobbypalazzi@gmail.com>
includes a regression test Co-authored-by: Ananya Rath <rath.ananya@gmail.com> Co-authored-by: Jacob Lefkowitz <jacoblefk@gmail.com>
…ator input Bugfix: identical on functions raises internal error instead of same error as <=>
ironm00n
force-pushed
the
sandbox-spring-2026-p1
branch
from
694aa59 to
a236fb4
Compare
Member
|
Cool! Just saw this. I'll see what's going on with the CI. |
Member
|
In terms of reviewing status, I see the original PRs, and I think I could make better incremental progress with individual PRs to this repo, but I'm not sure what planned workflow you have. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the non-lsp and non-doc related changes that were made by our sandbox team during the spring semester.
They correspond to the following PRs on our fork:
Fixes: brownplt/pyret-lang#1790, brownplt/pyret-lang#1700, brownplt/pyret-lang#1845, brownplt/pyret-lang#1855
Adds file icons to the VSCode extension and refactors
Ann::is-ignorablein preparation for our LSP changes.Once these are reviewed, we should probably go through the LSP on a call, before opening a PR.
cc: @zackbach, @jiang-h-y