Conversation
… in 3.0 Both rows sit in the settings catalog's "no screen in 2.x, undecided per row" bucket, but their behaviour is kept by the subsystem documents and each has a user asking for it: a held letter typing its capital is what BlackBerry 10 users expect (brobata#9), and swipe-to-accept has been silently off on every fresh install since the 1.0.2 screen removal (brobata#11). Give each its own Keep/Drop row naming the screen it needs, and point the native-provider decision in the trackpad document at the capture offered in brobata#11. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Daniel JB Clark <djbclark@gmail.com>
…ird-boundary defect D2 was carried on the maintainer's word and asked for a getevent capture; here it is from an Elite on V02.00.04 (X 0 to 1079, Y 0 to 599 at the kernel, X 0 to 1079 and Y 0 to 748.75 as Android reports them to the IME). With that measured, the native provider's 1440 px third boundaries are no longer an unverified suspicion: the right third begins at 960 of 1079, so the right-hand suggestion is nearly unreachable (brobata#14). Say so in section 3.3 and the quirks table, and tell 3.0 to take the boundaries from the device's declared range. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Daniel JB Clark <djbclark@gmail.com>
Author
|
Second commit: the |
…DPAD_UP key event Captured on an Elite on V02.00.04 with the native provider enabled: a flick up on the keys never reaches the IME's decor view as touchpad motion. system_server synthesizes KEYCODE_DPAD_UP (scanCode 19, deviceId of the touchPad device, source KEYBOARD) and delivers it to the app and the IME, which is why a flick moves the caret a line today. Record it as D7, note in 3.2 that the motion provider cannot fire on the Elite, and point the Keep/Drop decision at a keycode provider like the existing swipe-to-delete path (brobata#11). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Daniel JB Clark <djbclark@gmail.com>
…hpad motion with Scroll Assistant on The previous D7 attributed a synthetic KEYCODE_DPAD_UP to a flick. It was a drag in Unihertz's double-tap Cursor Assistant mode. A real flick, tested end to end today, reaches the IME's focused decor view as SOURCE_TOUCHPAD motion from the touchPad device, but only while Scroll Assistant is on; with it off nothing arrives. Eleven flicks were accepted and all three thirds reached once the boundaries came from the device's X range. Natural flicks cover 280 to 470 px, so the default 500 px threshold rejects most of them. Record the corrected fact, fix section 3.2, and propose keeping the native provider (brobata#11, brobata#14). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Daniel JB Clark <djbclark@gmail.com>
Author
|
Fourth commit corrects D7: the earlier D-pad attribution was Cursor Assistant mode, not a flick. The end-to-end test (#11) shows the native provider receives touchpad motion on the Elite while Scroll Assistant is on, with measured flick lengths, and the Keep/Drop row now proposes keeping it. |
swipe_to_delete has the same gap as the up-swipe: off by default with no screen since 1.0.2, and a 500 px distance that measured left flicks on the Elite (170 to 680 px) mostly fail. Put its two rows on the same proposed screen and take it out of the undecided bucket. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Daniel JB Clark <djbclark@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs only, against the 3.0 spec. No code.
Two preference groups sit in
settings-catalog.md§13 under "rows with no screen in 2.x: undecided per row", although their behaviour is kept by the subsystem documents and each has a user asking for a screen:long_press_modifier,long_press_threshold):keys-and-modifiers.md§8 keeps every mode, andshift(a held letter types its capital) is the BlackBerry 10 behaviour requested in Long press modifier (Shift for capitals) has no settings UI since the Modifiers screen was removed #9. feat(settings): add a Long Press behaviour screen under Enter key behaviour #10 implemented the screen on the 2.x code and was closed by the move to the 3.0 branch, so this row is where it lands now. Proposed: keep, with a Keyboard > "Long Press behaviour" screen (hold-time slider, modifier picker).trackpad_gestures_enabled,trackpad_gesture_add_word_enabled,trackpad_suggestion_swipe_threshold): since the 1.0.2 screen removal nothing reachable turns the gesture on, so the native provider has had no users to report on the Elite (Swipe up on the keys to accept a suggestion cannot be turned on:trackpad_gestures_enabledhas had no screen since 1.0.2 #11). Proposed: keep with a Keyboard > "Keyboard swipe" screen, conditional ontrackpad-caret-nav.mdkeeping the native provider. That document's "undecided, needs a capture" verdict is left as is and now points at Swipe up on the keys to accept a suggestion cannot be turned on:trackpad_gestures_enabledhas had no screen since 1.0.2 #11, where I have offered the capture from a Titan 2 Elite.Wording and placement are yours to change; the point is that the two rows stop being constants nobody chose.
Signed off under CONTRIBUTING.md's agreement.
🤖 Generated with Claude Code