Skip to content

vector: don't return empty slices from rip #7014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nwt merged 1 commit into from
Jun 2, 2026
Merged

vector: don't return empty slices from rip #7014

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions vector/apply.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,7 @@ func Apply(opt ApplyOpt, eval func(...Any) Any, vecs ...Any) Any {
}
results := make([]Any, len(d.Values))
for i, ripped := range rip(vecs, d) {
if len(ripped) > 0 {
results[i] = Apply(opt, eval, ripped...)
}
results[i] = Apply(opt, eval, ripped...)
}
// stitch removes nils and replaces Dynamics with their values.
return stitch(d.Tags, results)
Expand All @@ -58,17 +56,18 @@ func findDynamic(vecs []Any) (*Dynamic, bool) {
func rip(vecs []Any, d *Dynamic) iter.Seq2[int, []Any] {
return func(yield func(int, []Any) bool) {
for i, rev := range d.ReverseTagMap() {
var newVecs []Any
if len(rev) > 0 {
for _, vec := range vecs {
if vec == d {
newVecs = append(newVecs, d.Values[i])
} else {
newVecs = append(newVecs, Pick(vec, rev))
}
if len(rev) == 0 {
continue
}
ripped := make([]Any, len(vecs))
for j, vec := range vecs {
if vec == d {
ripped[j] = d.Values[i]
} else {
ripped[j] = Pick(vec, rev)
}
}
if !yield(i, newVecs) {
if !yield(i, ripped) {
return
}
}
Expand Down
Loading