Skip to content

Fixing Unit Tests and CI #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leogdion merged 2 commits into from
Feb 1, 2026
Merged

Fixing Unit Tests and CI #155

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f413f7
Remove network-dependent tests from URLSessionTests to fix Ubuntu CI …
leogdion Jan 31, 2026
4c075da
Merge branch 'subrepo' into subrepo-ci
leogdion Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 9 additions & 53 deletions Tests/BushelUtlitiesTests/URLSessionTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,66 +37,22 @@
import FoundationNetworking
#endif

internal final class URLSessionTests: XCTestCase {
// Note: These are integration tests that require network access
// For true unit tests, we'd need to mock URLSession

internal func testFetchLastModifiedWithValidURL() async throws {
// Use a known stable URL
let url = try XCTUnwrap(URL(string: "https://www.apple.com"))

let lastModified = await URLSession.shared.fetchLastModified(from: url)

// Should return a date (apple.com typically has Last-Modified)
// But we can't assert it exists reliably, so just verify no crash
_ = lastModified
}

internal func testFetchLastModifiedWithInvalidURL() async throws {
let url = try XCTUnwrap(
URL(string: "https://this-domain-definitely-does-not-exist-12345.com")
)
/// Tests for URLSession extensions that provide data fetching capabilities.
/// These tests validate the core functionality without requiring network access.
internal final class URLSessionTests: XCTestCase {
internal func testFetchLastModifiedWithInvalidURL() async throws {
let url = try XCTUnwrap(
URL(string: "https://this-domain-definitely-does-not-exist-12345.com")
)

let lastModified = await URLSession.shared.fetchLastModified(from: url)

// Should return nil on error
XCTAssertNil(lastModified)
}

internal func testFetchLastModifiedReturnsNilGracefully() async throws {
// URL without Last-Modified header
let url = try XCTUnwrap(URL(string: "https://httpbin.org/get"))

let lastModified = await URLSession.shared.fetchLastModified(from: url)

// May or may not have Last-Modified, but should not crash
_ = lastModified
}

internal func testFetchDataWithValidURL() async throws {
// Use a known stable API
let url = try XCTUnwrap(URL(string: "https://httpbin.org/json"))

let result = try await URLSession.shared.fetchData(from: url)

// Should return non-empty data
XCTAssertFalse(result.data.isEmpty)
}

internal func testFetchDataWithoutLastModifiedTracking() async throws {
let url = try XCTUnwrap(URL(string: "https://httpbin.org/json"))

let result = try await URLSession.shared.fetchData(
from: url,
trackLastModified: false
)

XCTAssertFalse(result.data.isEmpty)
XCTAssertNil(result.lastModified)
}

internal func testFetchDataWithInvalidURLThrows() async throws {
let url = try XCTUnwrap(URL(string: "https://this-definitely-does-not-exist-12345.com"))
internal func testFetchDataWithInvalidURLThrows() async throws {
let url = try XCTUnwrap(URL(string: "https://this-definitely-does-not-exist-12345.com"))

do {
_ = try await URLSession.shared.fetchData(from: url)
Expand Down
Loading