Repository navigation
test(conformance): Run the suite on hull on Linux - #680
Merged
Merged
Conversation
ananos
marked this pull request as ready for review
November 19, 2026 08:36
margkeka
force-pushed
the
fix/264-conformance-nerdctl
branch
from
November 19, 2026 12:40
38d3029 to
582655d
Compare
ananos
force-pushed
the
feat/conformance-hull-linux
branch
2 times, most recently
from
November 19, 2026 15:49
d5c39d0 to
65c1d1d
Compare
asapranidis
approved these changes
Nov 20, 2026
ananos
force-pushed
the
feat/conformance-hull-linux
branch
from
November 20, 2026 10:17
65c1d1d to
10532cd
Compare
hull on Linux now boots its guest behind hull's own gateway, the one that enforces a policy on hvi, but the suite booted only hvi and nerdctl. So there was no record a release could gate on for it. The hull-linux backend boots the hull the runtime bundle ships. Its record is filed under the bundle's tag, not hull's version: the bundle builds hull from a commit, so hull reports a pseudo-version, and a hull tag such as v0.1.0-rc22 reads like the bundle's own. The stack rows come from the bundle's pins: hull, urunc, hvi, hull-assets and containerd. The run is refused, boots nothing and writes no record when the hull that boots is not built from the commit the bundle pins, or when there is no bundle at all. The bundle's environment says BRIG_RUNTIME=nerdctl unless the shell said hull first. So the suite runs brig with BRIG_RUNTIME=hull for this backend, through the brigRuntime field the nerdctl backend uses, and the script asks brig-env.sh for the bundle's hull. The metadata case gets hvi's reason for an unproven target, since the gateway is the same. No verdict rule changes. Refs: #264 Signed-off-by: Anastassios Nanos <ananos@nofire.ai>
ananos
force-pushed
the
feat/conformance-hull-linux
branch
from
November 20, 2026 10:21
10532cd to
cfbd9ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The conformance suite (#264) runs on hull with hvi on macOS and, since #513, on nerdctl on Linux. hull on Linux is the third path, and the one we want to make the Linux default, so it needs the same suite and the same kind of record before that flip.
This adds a
hull-linuxbackend. It boots throughbrigwithBRIG_RUNTIME=hull, probes throughbrig shas on hvi, and files its record under the runtime bundle's tag: the bundle builds hull from a commit, so hull's own version names no release, and hull's tags read like the bundle's.#513 and #675 are on main. A real run of the full suite also wants #682, so no record is committed here yet.
Related issues
Refs: #264
Changes
test/conformance/backend.go: thehull-linuxbackend. The run is refused unless the commit inhull --versionis the bundle'sHULL_REF; the stack rows come from the bundle'spins.env(hull, urunc, hvi, hull-assets, containerd, rootlesskit, slirp4netns), the boot assets fromprovenance.json, the image digest fromhull inspect. nerdctl's rootless check and bundle row are shared helpers now.test/conformance/runner.go,cases.go,main.go,record.go: the case,BRIG_RUNTIME=hullfor this backend only, the metadata reason as on hvi (hull's gateway resets169.254.0.0/16).script/egress-conformance.sh -backend hull-linux, refused off Linux.releasing.md,manual-tests/egress-policy-linux.md,policies.md.test/conformance/hulllinux_test.go, negative ones included: another hull commit, a hull tag that reads like the bundle's, no commit, nerdctl in hull's place, noHULL_REF, no bundle. Each is refused, boots nothing and writes no record.Checklist
make allpasses (vet, test, build)script/smoke.shpassesgo test ./... -race, if the change touches concurrency, subprocesses or the daemonbrig run <agent>), if it touches the run, exec or credential pathNot run on a real host yet: it needs #675 and #682 first. The record from the first run lands in a follow-up commit here.