fix: workflow CI bug (submitted state) + product audit FAQ docs - #389
Merged
phertyameen merged 1 commit intoJul 28, 2026
Conversation
- Fix ReferenceError in ConfirmStep: add missing `submitted` state variable that was called via setSubmitted(true) but never declared, causing all 9 confirm-step tests to fail with 'submitted is not defined' (frontend/components/send-form/steps/confirm-step.tsx) - Add FAQ docs to bridgelet-product-audit/faq/ (closes bridgelet-org#335, bridgelet-org#336, bridgelet-org#337, bridgelet-org#340): - is-there-a-login-session.md: explains the no-session, sign-at-tx-time auth model - how-do-i-know-my-claim-link-is-safe.md: bearer-token nature, threat T-01, safe sharing - why-is-mobile-behind-the-web-app.md: zero CI coverage + services layer gap - how-does-bridgelet-relate-to-bridgelet-sdk-and-core.md: three-layer architecture All 141 unit tests pass.
|
@Oluwatobi843 is attempting to deploy a commit to the aminubabafatima8-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Oluwatobi843 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a workflow-blocking CI bug in the send form and adds four FAQ documents to the
bridgelet-product-audit/knowledge base.Bug fix:
ReferenceError: submitted is not definedFile:
frontend/components/send-form/steps/confirm-step.tsxThe
ConfirmStepcomponent calledsetSubmitted(true)and guarded the success view withif (submitted), but thesubmittedstate variable was never declared. This caused aReferenceErrorin all 9 confirm-step tests, blocking the Frontend CI workflow.Fix: Added the missing state declaration:
All 141 unit tests now pass.
FAQ documentation
Closes #335 —
bridgelet-product-audit/faq/is-there-a-login-session.mdCloses #336 —
bridgelet-product-audit/faq/how-do-i-know-my-claim-link-is-safe.mdCloses #337 —
bridgelet-product-audit/faq/why-is-mobile-behind-the-web-app.mdCloses #340 —
bridgelet-product-audit/faq/how-does-bridgelet-relate-to-bridgelet-sdk-and-core.mdEach FAQ is documentation-only, scoped to the new
bridgelet-product-audit/faq/folder. No changes tofrontend/ormobile/source code were needed for the FAQ items.Checklist
submittedstate variable declaredvitest run— 22 test files)frontend/ormobile/source changes for FAQ items