Skip to content

fix: 🐛 fix rerendering hooks in suspense in react 19 #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dennemark wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: 🐛 fix rerendering hooks in suspense in react 19 #362

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d33979
fix: :bug: fix useLayoutHook useImperativeHook not resolving dependen…
dennemark May 18, 2026
c44e673
fix: :fire: remove shouldSuspend from ReactBabylonJSHostConfig
dennemark May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions packages/react-babylonjs/src/ReactBabylonJSHostConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,6 @@ const ReactBabylonJSHostConfig: HostConfig<
setCurrentUpdatePriority: (newPriority: number) => void
onUncaughtError: (error: Error) => void
maySuspendCommit: () => boolean
shouldSuspend: () => boolean
preloadInstance: (args: any) => void
startSuspendingCommit: () => void
waitForCommitToBeReady: () => void
Expand Down Expand Up @@ -923,11 +922,7 @@ const ReactBabylonJSHostConfig: HostConfig<
},

maySuspendCommit() {
return true
},

shouldSuspend() {
return true
return false
},

preloadInstance(instance) {
Expand Down