Clean up yargs override#136
Merged
Merged
Conversation
Follow up on 59a1c9a. Using `yargs@16.6.2` allows us to use a unified `yargs` version for all supproted Node.js versions instead of having a workaround for Node.js 26 (and newer). See yargs/yargs#2514 for details on the `yargs` fix. This approach has two advantages: - It simplifies the build process by having a unified approach for every Node.js version - It (moderately) speeds up the Node.js 26 CI, as it can now use a straightforward `npm ci`, and no longer needs to perform package resolution with `npm install`. Related to brianc#132
Contributor
Author
|
Side note: yargs@17.7.3 contains the same fix. As this repo used 16.2.0 before this PR, I thought it was best to have the minimal change and not upgrade a major version. |
Owner
|
Makes total sense. Thanks - dependency hell is real and you are helping move us out of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on 59a1c9a.
Using
yargs@16.6.2allows us to use a unifiedyargsversion for all supproted Node.js versions instead of havng a workaround for Node.js 26 (and newer).See yargs/yargs#2514 for details on the
yargsfix.This approach has two advantages:
npm ci, and no longer needs to perform package resolution withnpm install.Related to #132