feat: install brev CLI to ~/.local/bin without requiring sudo#344
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
feat: install brev CLI to ~/.local/bin without requiring sudo#344devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
- Changed install-latest.sh and install-latest-linux.sh to install to ~/.local/bin instead of /usr/local/bin, removing the need for sudo - Added PATH warning if ~/.local/bin is not in the user's PATH - Updated README install instructions to remove sudo prefix - Removed sudo gating from the upgrade command's direct install path - Updated upgrade message to reflect new install location Co-Authored-By: Alec Fong <alecsanf@usc.edu>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes the brev CLI install scripts to install the binary to
~/.local/bininstead of/usr/local/bin, removing the requirement forsudoduring installation and upgrades.Install scripts (
bin/install-latest.sh,bin/install-latest-linux.sh):/usr/local/bin/brev(viasudo) →~/.local/bin/brev(nosudo)~/.local/binif it doesn't exist~/.local/binis not in$PATHUpgrade command (
pkg/cmd/upgrade/):sudo.Gaterdependency from the direct-install upgrade path~/.local/bin/brevREADME: Removed
sudoprefix from Linux and WSL install commands.Review & Testing Checklist for Human
/usr/local/bin/brevvia sudo, runningbrev upgradewill now place the new binary in~/.local/bin/brev— but the old binary in/usr/local/binwill likely shadow it on PATH. Consider whether the install script should detect and remove/warn about a stale/usr/local/bin/brev.~/.bashrc. Zsh users (default on macOS) would need~/.zshrcinstead. Verify this is acceptable for the Linux-only install script, or consider detecting$SHELL.$HOME/.local/binis acceptable for automated/CI use cases where the old sudo-based install was used.bash -c "$(curl -fsSL .../install-latest.sh)"on a clean Linux environment and verify the binary lands in~/.local/bin, the PATH warning appears if needed, andbrev --versionworks after adding to PATH.Notes
sudopackage and its usage inregister/deregistercommands (for netbird, systemctl) are intentionally left unchanged — those operations genuinely require elevated privileges.gaterfield removed.golangci-lintcould not run due to a pre-existing Go version mismatch in the environment (lint built with Go 1.23, project targets 1.24); this is not related to this change.Link to Devin session: https://app.devin.ai/sessions/0d03f0bca5b54573b7dd0109a22afe65
Requested by: @theFong