feat: resolve real user ID in analytics via UserStore#342
Merged
Conversation
Instead of manually passing user IDs through callers, analytics now accepts a UserStore interface and resolves the user ID directly. GetOrCreateAnalyticsID prefers the real user ID when available, falling back to the anonymous UUID.
patelspratik
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UserStoreinterface to the analytics package withGetCurrentUserID() (string, error)SetUserStore()is called once during init withnoLoginCmdStore, which already implements this methodGetOrCreateAnalyticsID()now tries the store first for the real user ID, falling back to the anonymous UUIDPersistentPostRunE— no more manual user resolution in cmd.goTest plan
brev lsstill reports analytics with user ID when logged inbrev logoutfollowed by a command uses the anonymous ID