Repository navigation
feat(conflate): log memory on the sub-step done lines - #938
Merged
Merged
Conversation
The conflate.match progress sampler stops after the first matching pass, so the memory peak while the exclusive-match candidates and the local coverage counts are alive never reached the log. Add the memstats fields to conflate.coverage (end of the first pass), conflate.match, conflate.deletion_candidates and conflate.write done lines. Fixes #932 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ttfb2LjteYzSoHhNa6cFxw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Sascha · project thread
Fixes #932.
The
conflate.match: progresssampler only runs during the first matching pass, so the log had no memory sample between the last progress line andconflate: end. That gap covers the time when the exclusive-match candidates and the local coverage counts are alive, which is probably the peak ofconflate.This adds a small
info_with_memory!macro inconflate/mod.rsthat logs the usual key-value pairs plus amemstatssnapshot (rss_bytes,rss_peak_bytes,rss_anon_bytes,rss_file_bytes,rss_shmem_bytes,cgroup_*). It is used on:conflate.coverage: done: the end of the first matching pass, with all exclusive-match candidates collectedconflate.deletion_candidates: done: while the local coverage counts are still aliveconflate.match: doneconflate.write: doneconflate.match: progress, which now uses the macro instead of its own copy of the fieldsNo change to the outputs.
Testing
cargo fmt --check,cargo clippy --all-targets -D warnings, and the unit tests pass.tippecanoeis not installed; they fail the same way on unchangedmain.Generated by Claude Code