feat: fail when global telemetry limits cannot be enforced#2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR tightens release safety: if global average telemetry limits are configured (
max_avg_latency_ms/max_avg_cost_usd) but telemetry is missing, the gate now fails instead of silently passing.Why
Teams are using agent quality gates to stop regressions in CI, but missing telemetry created a blind spot where configured global limits were never enforced.
What changed
max_avg_latency_msis set and no latency telemetry is presentmax_avg_cost_usdis set and no cost telemetry is presentValidation evidence
All checks run locally and passed.
python3 -m pytest7 passed in 0.04s)python3 -m pytest tests/test_evaluator.py -k 'global_latency_limit_requires_telemetry_when_configured or global_cost_limit_requires_telemetry_when_configured'2 passed, 4 deselected in 0.01s)python3 -m ruff check src testsAll checks passed!)python3 -m buildSuccessfully built ... .tar.gz and ... .whl)PYTHONPATH=src python3 -m agent_release_gate.cli evaluate --spec examples/spec.yaml --results examples/results.jsongate_passed=True,pass_rate=1.0)Risk
Low. Change is scoped to gate decision logic for already-configured global limits.