Update openai provider types#333
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 166969f553
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "Codex (@codex) address that feedback".
| if let Ok(reasoning_value) = serde_json::to_value(reasoning) { | ||
| extras_map.insert("reasoning".into(), reasoning_value); |
There was a problem hiding this comment.
When a Responses request has a reasoning object without effort (for example only summary or only the new context), serializing the typed OpenAIReasoning here stores "effort": null in extras because OpenAIReasoning::effort does not have skip_serializing_if. request_from_universal then prefers this raw extras value, so a same-provider round trip changes the original payload by adding an explicit null field, breaking exact/lossless round-trip behavior; preserve the raw reasoning value or skip None for effort as well.
Useful? React with 👍 / 👎.
1 participant
Automated update of Lingua provider types.
Provider:
openaiFeedback: comment
/bt goodor/bt badto log review feedback to the Braintrust trace.Validation
./pipelines/generate-provider-types.sh openai: failure./pipelines/generate-provider-types.sh openai: successmake generate-types: successmake generate-types: successcargo fmt --all: successcargo build --all-features: successcargo clippy --all-targets --all-features -- -D warnings: successmake typed-boundary-check: successcargo test -p coverage-report --test cross_provider_test cross_provider_transformations_have_no_unexpected_failures: successThis PR is created even when validation fails so the generated update and repair attempt are available for manual follow-up.