-
Notifications
You must be signed in to change notification settings - Fork 1
Update google provider types #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
github-actions
wants to merge
1
commit into
main
Choose a base branch
from
update-google-provider-types-2b5468d0-28788427282
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+6,308
−5,903
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # Google provider type update notes | ||
|
|
||
| ## Changes in this update | ||
|
|
||
| ### `ComputerUse` struct (additive, optional fields) | ||
|
|
||
| Two new optional fields added: | ||
| - `disabled_safety_policies: Option<Vec<DisabledSafetyPolicy>>` -- safety policies to disable during computer use | ||
| - `enable_prompt_injection_detection: Option<bool>` -- flag for prompt injection detection | ||
|
|
||
| ### New `DisabledSafetyPolicy` enum | ||
|
|
||
| Eight variants: `AccountCreation`, `CommunicationTool`, `DataModification`, `FinancialTransactions`, `LegalTermsAndAgreements`, `SafetyPolicyUnspecified`, `SensitiveDataModification`, `UserConsentManagement`. | ||
|
|
||
| ### `Environment` enum (additive variants) | ||
|
|
||
| Two new variants: `EnvironmentDesktop`, `EnvironmentMobile` (joining existing `EnvironmentBrowser`, `EnvironmentUnspecified`). | ||
|
|
||
| ### Generator improvement | ||
|
|
||
| New `strip_quicktype_preamble()` function strips non-Rust diagnostic lines that CI environments or quicktype may emit before generated code. | ||
|
|
||
| ## Adapter/converter impact | ||
|
|
||
| No hand-written code changes required. All changes are within the `ComputerUse` type hierarchy, which is a field on the `Tool` struct. The tool converter already does not convert `computer_use` to/from `UniversalTool` (pre-existing gap -- it handles `function_declarations`, `google_search`, `code_execution`, `google_search_retrieval`, and `url_context` only). The new fields and variants are all optional/additive, so serialization and deserialization remain backward-compatible. | ||
|
|
||
| ## Items for human review | ||
|
|
||
| **`computer_use` tool conversion**: If cross-provider computer-use support is planned, the `Tool.computer_use` field needs a `UniversalTool` representation (likely a new builtin tool type). The new `DisabledSafetyPolicy` and expanded `Environment` variants would need to be modeled as part of that builtin tool's config. This is a pre-existing gap, not caused by this update. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When quicktype or a CI wrapper emits a diagnostic preamble that contains a blank line before the first real Rust line, this predicate selects that blank line as the start of the generated source. Any subsequent non-Rust diagnostic lines remain in
generated.rs, and the latercargo fmtresult is ignored, so the generator can report success after writing an uncompilable file. Please skip empty lines until a real Rust token/comment has been found, then preserve blanks from there.Useful? React with 👍 / 👎.