Update anthropic provider types#328
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58d1930c88
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "Codex (@codex) address that feedback".
| pub name: String, | ||
| /// How this tool's result blocks appear in the API response when the result was consumed by a completed code_execution call in the same turn. 'full' returns the complete content (default). 'excluded' drops the nested server_tool_use and result block pair entirely. Results from direct calls, or from code_execution calls that paused before completing, are always returned in full so they can be sent back on the next turn. | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub response_inclusion: Option<String>, |
There was a problem hiding this comment.
Use the generated enum for response_inclusion
The new Anthropic schema restricts response_inclusion to "full" or "excluded", and this commit already generates a ResponseInclusion enum for those values. Leaving this field (and the matching field on WebSearchTool20260318) as Option<String> lets callers build requests with arbitrary values that Anthropic will reject, so the generated provider type no longer matches the API for the new 20260318 tools. Please wire both fields to Option<ResponseInclusion>.
Useful? React with 👍 / 👎.
Automated update of Lingua provider types.
Provider:
anthropicFeedback: comment
/bt goodor/bt badto log review feedback to the Braintrust trace.Validation
./pipelines/generate-provider-types.sh anthropic: successmake generate-types: successmake generate-types: successcargo fmt --all: successcargo build --all-features: successcargo clippy --all-targets --all-features -- -D warnings: successmake typed-boundary-check: successcargo test -p coverage-report --test cross_provider_test cross_provider_transformations_have_no_unexpected_failures: successThis PR is created even when validation fails so the generated update and repair attempt are available for manual follow-up.