-
Notifications
You must be signed in to change notification settings - Fork 1
test baseten responses endpoint against lingua testcases #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ken Jiang (knjiang)
wants to merge
2
commits into
main
Choose a base branch
from
06-30-test_baseten_responses_endpoint_against_lingua_testcases
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| import OpenAI from "openai"; | ||
| import { CaptureResult, ExecuteOptions, ProviderExecutor } from "../types"; | ||
| import { | ||
| allTestCases, | ||
| getCaseNames, | ||
| getCaseForProvider, | ||
| hasExpectation, | ||
| } from "../../cases"; | ||
| import { BASETEN_BASE_URL, BASETEN_MODEL } from "../../cases/models"; | ||
| import { | ||
| executeOpenAIResponses, | ||
| openaiResponsesExecutor, | ||
| } from "./openai-responses"; | ||
|
|
||
| type BasetenResponsesRequest = OpenAI.Responses.ResponseCreateParams; | ||
| type BasetenResponsesResponse = OpenAI.Responses.Response; | ||
|
|
||
| export const basetenResponsesCases: Record<string, BasetenResponsesRequest> = | ||
| {}; | ||
|
|
||
| getCaseNames(allTestCases).forEach((caseName) => { | ||
| if (hasExpectation(allTestCases, caseName)) { | ||
| return; | ||
| } | ||
|
|
||
| const explicitCase = getCaseForProvider( | ||
| allTestCases, | ||
| caseName, | ||
| "baseten-responses" | ||
| ); | ||
| if (explicitCase) { | ||
| basetenResponsesCases[caseName] = explicitCase; | ||
| return; | ||
| } | ||
|
|
||
| const responsesCase = getCaseForProvider(allTestCases, caseName, "responses"); | ||
| if (responsesCase) { | ||
| basetenResponsesCases[caseName] = { | ||
| ...responsesCase, | ||
| model: BASETEN_MODEL, | ||
| }; | ||
| } | ||
| }); | ||
|
|
||
| const BASETEN_HOST = BASETEN_BASE_URL.replace(/\/v1\/?$/, ""); | ||
|
|
||
| export function executeBasetenResponses( | ||
| caseName: string, | ||
| payload: BasetenResponsesRequest, | ||
| options?: ExecuteOptions | ||
| ): Promise< | ||
| CaptureResult<BasetenResponsesRequest, BasetenResponsesResponse, unknown> | ||
| > { | ||
| return executeOpenAIResponses(caseName, payload, { | ||
| ...options, | ||
| baseURL: BASETEN_HOST, | ||
| apiKey: process.env.BASETEN_API_KEY, | ||
| }); | ||
| } | ||
|
|
||
| export const basetenResponsesExecutor: ProviderExecutor< | ||
| BasetenResponsesRequest, | ||
| BasetenResponsesResponse, | ||
| unknown | ||
| > = { | ||
| name: "baseten-responses", | ||
| cases: basetenResponsesCases, | ||
| execute: executeBasetenResponses, | ||
| ignoredFields: openaiResponsesExecutor.ignoredFields, | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
payloads/snapshots/chatCompletionsAnthropicCacheControlParam/baseten/followup-request.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
BASETEN_API_KEYis unset butOPENAI_API_KEYis set, this passesundefinedintoexecuteOpenAIResponses; that helper defaultsapiKeytoprocess.env.OPENAI_API_KEYwhile the base URL is stillBASETEN_HOST, so ordinary OpenAI-only capture environments can send an OpenAI key to Baseten and create/overwrite auth-error snapshots. Add an explicitBASETEN_API_KEYcheck here, like the transform capture path does, instead of falling through to the OpenAI key fallback.Useful? React with 👍 / 👎.