-
Notifications
You must be signed in to change notification settings - Fork 1
Update google provider types #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
github-actions
wants to merge
1
commit into
main
Choose a base branch
from
update-google-provider-types-e061090f-28369353791
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # Google provider type update notes | ||
|
|
||
| ## Changes in this update | ||
|
|
||
| ### `ComputerUse` struct: two new optional fields | ||
|
|
||
| - `disabled_safety_policies: Option<Vec<DisabledSafetyPolicy>>` — allows disabling specific safety policies for computer use sessions. | ||
| - `enable_prompt_injection_detection: Option<bool>` — enables prompt injection detection on computer-use requests. | ||
|
|
||
| ### New `DisabledSafetyPolicy` enum | ||
|
|
||
| Eight variants: `AccountCreation`, `CommunicationTool`, `DataModification`, `FinancialTransactions`, `LegalTermsAndAgreements`, `SafetyPolicyUnspecified`, `SensitiveDataModification`, `UserConsentManagement`. | ||
|
|
||
| ### `Environment` enum: two new variants | ||
|
|
||
| - `EnvironmentDesktop` — desktop environment for computer use. | ||
| - `EnvironmentMobile` — mobile environment for computer use. | ||
|
|
||
| ## Adapter changes made | ||
|
|
||
| Added `computer_use` as a builtin tool type in the `GoogleTool` <-> `UniversalTool` conversion (`convert.rs`). Previously, `computer_use` was silently dropped during tool conversion. It now roundtrips through `UniversalTool::builtin` with its full typed config (including the new fields), matching the existing pattern for `google_search`, `code_execution`, `google_search_retrieval`, and `url_context`. | ||
|
|
||
| ## No changes needed | ||
|
|
||
| - No new `FinishReason` variants were added, so no finish-reason mapping updates are required. | ||
| - No new roles or content part types were added. | ||
| - All new fields are optional and serialize/deserialize correctly via serde without adapter changes. | ||
|
|
||
| ## Pre-existing gaps not addressed | ||
|
|
||
| - `file_search` and `google_maps` tool types on the `GoogleTool` struct are not yet handled in the builtin tool conversion (same as before this update — they were not modified in this diff). |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a universal Google builtin
computer_usetool has malformed or missingconfig, this branch turns the deserialization failure intoNone; the code then still pushes the defaultGoogleToolafter the match, so the generated Google request contains an empty{}tool instead of surfacing the bad config. That hides the conversion error and can produce an invalid provider request for user-supplied universal tools.Useful? React with 👍 / 👎.