fix: functions push producing empty python_bundle.sources on Windows#259
Open
Cedric / ViaDézo1er (viadezo1er) wants to merge 1 commit into
Conversation
Path::canonicalize emits \\?\ verbatim paths that the Python runner can't reconcile against a clean cwd, so every source was filtered out. dunce::canonicalize to strip the prefix, with a matching guard in the Python runner
Contributor
|
Latest downloadable build artifacts for this PR commit
Available artifact names
|
Cedric / ViaDézo1er (viadezo1er)
requested review from
Abhijeet Prasad (AbhiPrasad) and
Parker Henderson (parkerhendo)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Path::canonicalize emits \?\ verbatim paths that the Python runner
can't reconcile against a clean cwd, so every source was filtered out.
dunce::canonicalize to strip the prefix, with a matching guard in
the Python runner
After running
bt functions push .\answer_relevancy.py -p "Windows bt function push issue" --language python --runner .\.venv\Scripts\python.exe --requirements requirements.txt --if-exists replace -yon Windows:(answer_relevancy hardcodes the project so it ignored the -p flag)
https://linear.app/braintrustdata/issue/SDK-9/bt-functions-push-fails-on-windows-with-empty-python-bundlesources