Fix tests for updated span attributes and API endpoints#2
Merged
Conversation
Ankur Goyal (ankrgyl)
commented
Jul 12, 2025
Ankur Goyal (ankrgyl)
commented
Contributor
- Update BraintrustSpanProcessorTest to use PARENT attribute instead of deprecated attributes
- Update BraintrustTracingTest to use PARENT attribute format
- Fix API client tests to use correct v1 endpoints (/v1/project, /v1/dataset)
- Tests now passing: reduced from 13 failures to 6
- Update BraintrustSpanProcessorTest to use PARENT attribute instead of deprecated attributes - Update BraintrustTracingTest to use PARENT attribute format - Fix API client tests to use correct v1 endpoints (/v1/project, /v1/dataset) - Tests now passing: reduced from 13 failures to 6
Java 11 is not compatible with the modern Java features used in this project: - Text blocks (Java 15+) - Pattern matching for instanceof (Java 14+) - Records (Java 14+) The project already requires Java 17 as documented in the README.
- Update CI to remove Java 11 (incompatible with modern Java features) - Fix test expectations to match actual span names (eval vs evaluation) - Fix streaming tests to complete stream before checking spans - Update span attribute assertions to match implementation - Remove unused imports All 118 tests now pass successfully. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.