api nitpicks

examples/src/main/java/dev/braintrust/examples/ExperimentExample.java

@@ -14,7 +14,7 @@
 public class ExperimentExample {
     public static void main(String[] args) throws Exception {
         var config = BraintrustConfig.fromEnvironment();
-        var openTelemetry = BraintrustTracing.quickstart(config, true);
+        var openTelemetry = BraintrustTracing.of(config, true);
         var openAIClient = BraintrustOpenAI.wrapOpenAI(openTelemetry, OpenAIOkHttpClient.fromEnv());
 
         Function<String, String> getFoodType =

examples/src/main/java/dev/braintrust/examples/OpenAIInstrumentationExample.java

@@ -16,7 +16,7 @@ public static void main(String[] args) throws Exception {
                     "\nWARNING envar OPEN_AI_API_KEY not found. This example will likely fail.\n");
         }
         var braintrustConfig = BraintrustConfig.fromEnvironment();
-        var openTelemetry = BraintrustTracing.quickstart(braintrustConfig, true);
+        var openTelemetry = BraintrustTracing.of(braintrustConfig, true);
         var tracer = BraintrustTracing.getTracer(openTelemetry);
         OpenAIClient openAIClient =
                 BraintrustOpenAI.wrapOpenAI(openTelemetry, OpenAIOkHttpClient.fromEnv());

examples/src/main/java/dev/braintrust/examples/SimpleOpenTelemetryExample.java

@@ -6,7 +6,7 @@
 public class SimpleOpenTelemetryExample {
     public static void main(String[] args) throws Exception {
         var braintrustConfig = BraintrustConfig.fromEnvironment();
-        var openTelemetry = BraintrustTracing.quickstart(braintrustConfig, true);
+        var openTelemetry = BraintrustTracing.of(braintrustConfig, true);
         var tracer = BraintrustTracing.getTracer(openTelemetry);
 
         var span = tracer.spanBuilder("hello-java").startSpan();

src/main/java/dev/braintrust/api/ApiException.java

@@ -1,7 +1,6 @@
 package dev.braintrust.api;
 
-/** Exception thrown when API operations fail. */
-public class ApiException extends RuntimeException {
+class ApiException extends RuntimeException {
 
     public ApiException(String message) {
         super(message);

src/main/java/dev/braintrust/config/BaseConfig.java

@@ -18,7 +18,8 @@ class BaseConfig {
 
     protected <T> @Nonnull T getConfig(@Nonnull String settingName, @Nonnull T defaultValue) {
         Objects.requireNonNull(defaultValue);
-        return getConfig(settingName, defaultValue, (Class<T>) defaultValue.getClass());
+        return Objects.requireNonNull(
+                getConfig(settingName, defaultValue, (Class<T>) defaultValue.getClass()));
     }
 
     protected <T> @Nullable T getConfig(

src/main/java/dev/braintrust/config/BraintrustConfig.java

@@ -80,7 +80,7 @@ public Optional<String> getBraintrustParentValue() {
     /** fetch all project info and IDs from the braintrust api */
     public URI fetchProjectURI() {
         try {
-            var client = new BraintrustApiClient(this);
+            var client = BraintrustApiClient.of(this);
             var orgAndProject = client.getProjectAndOrgInfo().orElseThrow();
             return new URI(
                     appUrl()

src/main/java/dev/braintrust/eval/Eval.java

@@ -35,7 +35,7 @@ public final class Eval<INPUT, OUTPUT> {
     private Eval(Builder<INPUT, OUTPUT> builder) {
         this.experimentName = builder.experimentName;
         this.config = Objects.requireNonNull(builder.config);
-        this.client = new BraintrustApiClient(config);
+        this.client = BraintrustApiClient.of(config);
         if (null == builder.projectId) {
             this.orgAndProject = client.getProjectAndOrgInfo().orElseThrow();
         } else {

src/main/java/dev/braintrust/instrumentation/openai/BraintrustOpenAI.java

@@ -5,6 +5,7 @@
 import io.opentelemetry.api.OpenTelemetry;
 
 public class BraintrustOpenAI {
+    /** Instrument openai client with braintrust traces */
     public static OpenAIClient wrapOpenAI(OpenTelemetry openTelemetry, OpenAIClient openAIClient) {
         if ("true".equalsIgnoreCase(System.getenv("BRAINTRUST_X_OTEL_LOGS"))) {
             return io.opentelemetry.instrumentation.openai.v1_1.OpenAITelemetry.builder(

src/main/java/dev/braintrust/log/BraintrustLogger.java

@@ -21,6 +21,7 @@ public final class BraintrustLogger {
 
     static {
         // BT logger will filter log levels so make the impl most permissive
+        // FIXME: Don't ship this -- we don't want to set common slf4j log properties
         System.setProperty("org.slf4j.simpleLogger.defaultLogLevel", "trace");
         // Initialize with default SLF4J implementation
         var defaultLogger = LoggerFactory.getLogger(LOGGER_NAME);

src/main/java/dev/braintrust/trace/BraintrustLogExporter.java

@@ -16,7 +16,7 @@
  * Custom log exporter for Braintrust that adds the x-bt-parent header dynamically based on log
  * attributes.
  */
-public class BraintrustLogExporter implements LogRecordExporter {
+class BraintrustLogExporter implements LogRecordExporter {
 
     private final BraintrustConfig config;
     private final String logsEndpoint;

src/main/java/dev/braintrust/trace/BraintrustSpanExporter.java

@@ -16,7 +16,7 @@
  * Custom span exporter for Braintrust that adds the x-bt-parent header dynamically based on span
  * attributes.
  */
-public class BraintrustSpanExporter implements SpanExporter {
+class BraintrustSpanExporter implements SpanExporter {
 
     private final BraintrustConfig config;
     private final String tracesEndpoint;

src/main/java/dev/braintrust/trace/BraintrustTracing.java

@@ -53,7 +53,7 @@ public static Tracer getTracer(OpenTelemetry openTelemetry) {
      * `enable` method.
      */
     public static OpenTelemetry quickstart() {
-        return quickstart(BraintrustConfig.fromEnvironment(), true);
+        return of(BraintrustConfig.fromEnvironment(), true);
     }
 
     /**
@@ -62,8 +62,7 @@ public static OpenTelemetry quickstart() {
      * If you're looking for more options for configuring Braintrust and OpenTelemetry, consult the
      * `enable` method.
      */
-    public static OpenTelemetry quickstart(
-            @Nonnull BraintrustConfig config, boolean registerGlobal) {
+    public static OpenTelemetry of(@Nonnull BraintrustConfig config, boolean registerGlobal) {
         var tracerBuilder = SdkTracerProvider.builder();
         var loggerBuilder = SdkLoggerProvider.builder();
         var meterBuilder = SdkMeterProvider.builder();

src/test/java/dev/braintrust/config/BaseConfigTest.java

@@ -3,6 +3,7 @@
 import static org.junit.jupiter.api.Assertions.*;
 
 import java.util.Map;
+import javax.annotation.Nonnull;
 import org.junit.jupiter.api.Test;
 
 public class BaseConfigTest {
@@ -186,21 +187,25 @@ static class TestConfig extends BaseConfig {
             super(envOverrides);
         }
 
+        @Nonnull
         @Override
-        public <T> T getConfig(String settingName, T defaultValue) {
+        public <T> T getConfig(@Nonnull String settingName, @Nonnull T defaultValue) {
             return super.getConfig(settingName, defaultValue);
         }
 
         @Override
-        public <T> T getConfig(String settingName, T defaultValue, Class<T> settingClass) {
+        public <T> T getConfig(
+                @Nonnull String settingName, T defaultValue, @Nonnull Class<T> settingClass) {
             return super.getConfig(settingName, defaultValue, settingClass);
         }
 
+        @Nonnull
         @Override
         public String getRequiredConfig(String settingName) {
             return super.getRequiredConfig(settingName);
         }
 
+        @Nonnull
         @Override
         public <T> T getRequiredConfig(String settingName, Class<T> settingClass) {
             return super.getRequiredConfig(settingName, settingClass);

src/test/java/dev/braintrust/config/BraintrustConfigTest.java

@@ -1,15 +1,26 @@
 package dev.braintrust.config;
 
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.assertEquals;
 
 import org.junit.jupiter.api.Test;
 
 class BraintrustConfigTest {
     @Test
-    void parentLogic() {
+    void parentDefaultsToProjectName() {
         var defaultConfig = BraintrustConfig.of("BRAINTRUST_API_KEY", "foobar");
-        assertTrue(
-                defaultConfig.getBraintrustParentValue().isPresent(),
-                "default config should have a parent");
+        assertEquals(
+                "project_name:" + defaultConfig.defaultProjectName().orElseThrow(),
+                defaultConfig.getBraintrustParentValue().orElseThrow());
+    }
+
+    @Test
+    void parentUsesProjectId() {
+        var defaultConfig =
+                BraintrustConfig.of(
+                        "BRAINTRUST_API_KEY", "foobar",
+                        "BRAINTRUST_DEFAULT_PROJECT_ID", "12345");
+        assertEquals(
+                "project_id:" + defaultConfig.defaultProjectId().orElseThrow(),
+                defaultConfig.getBraintrustParentValue().orElseThrow());
     }
 }