Revert "add responses to model flavor (#893)"#906
Conversation
This reverts commit d323865.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2fb545d5e7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| "embedding", | ||
| "responses", | ||
| ] as const; | ||
| export const ModelFlavors = ["chat", "completion", "embedding"] as const; |
There was a problem hiding this comment.
When an API secret defines metadata.customModels for a Responses API-only/internal model with flavor: "responses", BaseMetadataSchema validates each entry with ModelSchema (packages/proxy/schema/secrets.ts:7). With this enum narrowed back to only chat/completion/embedding, APISecretSchema rejects those configured secrets before /responses requests can be routed, regressing the custom Responses model use case that the reverted change enabled.
Useful? React with 👍 / 👎.
2 participants
This reverts commit d323865.