Uplift from mailgun/manners fork - #42
Open
horkhe wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
@lionelbarrow please take a look |
Contributor
Author
|
It has been more then a month since the PR was proposed. Is anybody maintaining this repo? |
Contributor
Author
|
Third time's the charm? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to bring all features implemented in the mailgun/manners fork to the upstream so that projects like vulcand can stop depending on the fork and start using the upstream.
The changes are:
GetFilefunction that returns a listener socket file handler that can be used to handover to a child process during hot server code reload;New...functions for convenience;The changes have been originally implemented by @klizhentas, I have just rebased them to the upstream master.