Repository navigation
Fig. 5 with its links in the review PDF, from bbqs-standards as a submodule - #17
Open
yarikoptic-gitmate wants to merge 2 commits into
Open
yarikoptic-gitmate wants to merge 2 commits into
yarikoptic-gitmate wants to merge 2 commits into
Conversation
\includegraphics keeps the drawing of a PDF figure but drops its links, so: - make pdf renders each SVG figure of the draft to build/<path>.pdf with rsvg-convert, which keeps the links of the SVG, and lists them with tools/pdf/pdflinks.py (pypdf) in build/<path>.links.tex - tools/pdf/figures.lua puts an SVG figure in as \linkedgraphics, which (tools/pdf/header.tex) draws its links again over it, as invisible link annotations of explicit size (XeTeX, pdfTeX, and LuaTeX) - Fig. 5 in the draft is now the SVG (vector, 118 links) instead of the PNG preview - CI installs librsvg2-bin, fonts-liberation, python3-pypdf Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PvaGRbLpDegB5uBvgecaiL
Fig. 5 is also Figure 2 of the BBQS standards guideline, so it moves to brain-bbqs/bbqs-standards (content/guidelines/figures/bbqs-standards-stack.svg and .svgtune), and the paper includes that repository as the bbqs-standards submodule (issue #15): - draft: Fig. 5 is bbqs-standards/content/guidelines/figures/ bbqs-standards-stack.svg, which make pdf puts in with its links - the SVG was produced from the PowerPoint draft here (fig5_bbqs_stack_design.pptx and fig5_bbqs_stack.yaml, by tools/pptx2svg.py), but is to be refined from now on as the SVG itself, so the .pptx, .yaml, PNG preview, and tools/pptx2svg.py are removed and not carried over; figures/fig5_bbqs_stack/README.md points to the new home - make fig5 only writes the svgtune walkthrough (and is no longer part of make figures) - CI checks out the submodule; README says to clone with --recurse-submodules Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PvaGRbLpDegB5uBvgecaiL
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Two commits, following #13 and #15:
1. Review PDF: Fig. 5 from its SVG, with the links of the figure
The draft embedded the PNG preview of Fig. 5, so the PDF had none of the 118 links of the SVG. Converting the SVG to PDF alone would not fix that:
\includegraphicsdrops the links of an included PDF (XeLaTeX, pdfLaTeX, and LuaLaTeX alike).make pdfrenders each SVG figure of the draft tobuild/<path>.pdfwithrsvg-convert, which keeps the SVG's links.tools/pdf/pdflinks.py(pypdf) then lists them inbuild/<path>.links.tex.tools/pdf/figures.luaputs an SVG figure in as\linkedgraphics. That macro (tools/pdf/header.tex) draws the links again over the figure as invisible link annotations of explicit size. A\hrefaround an empty box does not work: xdvipdfmx sizes a link by the glyphs inside it, so the link comes out empty. The macro works with XeTeX, pdfTeX, and LuaTeX, sopaper.texalso works for a journal build.librsvg2-bin fonts-liberation python3-pypdf.2. Fig. 5 now lives in bbqs-standards, included as a submodule
As agreed in #15, Fig. 5 moves to brain-bbqs/bbqs-standards, where it is Figure 2 of the guidelines (brain-bbqs/bbqs-standards#5). The paper includes that repository as the
bbqs-standards/submodule, which tracksmain.draft/12_figures_tables.mdusesbbqs-standards/content/guidelines/figures/bbqs-standards-stack.svg.fig5_bbqs_stack_design.pptx,fig5_bbqs_stack.yaml,tools/pptx2svg.py). It will be refined as the SVG itself from now on, so those files and the PNG preview are removed rather than moved.figures/fig5_bbqs_stack/README.mdpoints to the new home.make fig5only writes the svgtune walkthrough.--recurse-submodules.Merge brain-bbqs/bbqs-standards#5 first, then update the submodule here. The submodule currently points at
0e59722, the head of that PR, which is fetchable throughrefs/pull/5/head. If #5 is squash-merged, point it at the resulting commit onmain:git submodule update --remote bbqs-standards.Testing
make pdfgives 30 pages, with all 118 links of Fig. 5 on page 22 (171 annotations in total, 53 before). The link rectangles were drawn over a render of the page and sit exactly on their boxes and words, including the per-word links inside a box.make checkpasses.draft/12_figures_tables.mdshows no Fig. 5. The review PDF is not affected.Generated by Claude Code