Repository navigation
Fetched the built commit without checking it out in the Chromatic publish job - #19
Merged
Merged
Conversation
…lish job Run inside a checkout of the built commit, the Chromatic CLI loads its Storybook config and starts the package manager it detects there, which honours repository-local configuration, so a fork's pull request to an app generated from this template could read the project tokens (reproduced with chromatic 18.9.4 and a .yarnrc). The publish job now points HEAD at the commit and writes only a stub package.json, and picks the token by the secret's name. Both come from setup-chromatic at con/skills c65afe5, which apm.yml now pins. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DQrzw3QuYxA1bV48ZgQcor
CodyCBakerPhD
pushed a commit
to con/skills
that referenced
this pull request
Nov 19, 2026
A computed secrets[...] name makes GitHub send every repository and organization secret to the runner (CodeQL: excessive secrets exposure, flagged on brain-bbqs/bbqs-web-app-template#19). Each token now sits behind its own condition instead, which keeps a missing secret empty so the CLI stops rather than uploading into the other project. Also takes the review's wording for the README template's first-baseline step. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DQrzw3QuYxA1bV48ZgQcor
A computed secrets[...] name makes GitHub send every repository and organization secret to the runner (CodeQL: excessive secrets exposure). Each token now sits behind its own condition, which keeps a missing secret empty so the CLI stops rather than uploading into the other project. From setup-chromatic at con/skills 71e788c, which apm.yml now pins. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DQrzw3QuYxA1bV48ZgQcor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security follow-up to #17, from the review of con/skills#50:
.yarnrc).The job now fetches the commit without checking it out (
HEADplus a stubpackage.json), and references each token statically behind its own condition, so a missing one stays empty and no other secret reaches the runner (CodeQL flagged an indexedsecrets[...]form tried in between).The template's own guard on the publish job is unchanged, so the template itself still never publishes.
apm.ymlpinssetup-chromaticat setup-chromatic: build without a token and publish from the default branch con/skills#50's head (71e788c); it should move to that PR's merge commit once it lands.No version bump or changelog entry: nothing under
src/,configs/,index.htmlorpackage.jsonchanged.Checked locally:
apm installandapm audit --ci,actionlint,npm run format:checkandpre-commit run --all-files; the fixed fetch against the same.yarnrcattack ran nothing and reached authentication.Original prompt
open the matching PR on web-app-template too
adjjust #17 to use the con/skills setup chromatic and improve the skill there in the way you ust did
🤖 Generated with Claude Code
https://claude.ai/code/session_01DQrzw3QuYxA1bV48ZgQcor