Repository navigation
Conversation
A collaborator is someone onboarded without another role: not on the award, or not in the awardee lab (nadernik, 2026-11-19). normalize_grant_role stores the token since 20261118140000, applied from #520 and committed here as applied. onboard_member still sent any role it didn't list to research_staff, so onboarding a collaborator stored research_staff. - 20261119170000: onboard_member keeps 'collaborator'; role_label_from_token gives 'Collaborator'. - KG: project_role_enum and shape #4 gain the token; OWL/SHACL updated to match. - The admin onboarding dialog and bbqs-mcp's onboard_member help offer it. - tests/guards/onboard-role-parity: onboard_member's role CASE equals normalize_grant_role's tokens, and every role menu sends a role the roster accepts. Fails without 20261119170000. Refs #496, #520
Contributor
🤖 Triage: Class C →
|
Contributor
🛑 Class C — this touches a danger layerPer the constitution (Development Workflow) danger-layer changes are spec-driven. Before this can merge, a maintainer must:
This gate is here because a small-looking diff to |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decision (nadernik, 2026-11-19):
collaboratoris a role for people onboarded without another role: someone who isn't on the award, or isn't in the awardee lab.What was wrong.
normalize_grant_rolehas stored the token since20261118140000, which was applied from #520. Butonboard_membernormalises roles with its own CASE and sends anything it doesn't list toresearch_staff. So onboarding a collaborator through MCP or the admin console storedresearch_staff, with no error.What changes:
20261118140000_role_vocabulary_collaborator.sqlis feat(kg): read-only MCP server over the exported graph #520's file, committed unchanged because it's live in production. The parity guard reads the latestnormalize_grant_role, so it needs the file here.20261119170000_onboard_collaborator.sqladds one line to each of two functions:onboard_memberkeepscollaborator.role_label_from_token('collaborator')returnsCollaborator, so a new collaborator'sinvestigators.rolelabel isn't left empty.20260811120000's plus that one line. The live bodies match it (compared, ignoring comments and spacing).project_role_enum(with a description) and shape Test issue from Lovable #4 gain the token.bbqs.owl.ttlandbbqs.shapes.gen.ttlare edited by hand to match, because the local LinkML environment is broken. CI's--check-generatedregenerates both and compares them.bbqs-mcp'sonboard_memberrole help lists it. That help text only goes live with a deploy ofbbqs-mcp.tests/guards/onboard-role-paritychecks two things.onboard_member's role CASE must equalnormalize_grant_role's tokens, and every role in the onboarding dialog and the roster editor must be one the roster accepts. It fails without20261119170000. Locally, all 104 guards andtscpass.Groups:
sync-member-groupsgives a collaboratorconsortium@and their working groups. They don't getpi@,young-investigators@ordcaic-all@.To apply: SQL editor, project
vpexxhfpvghlejljwpvt. The last statement should showlabel = Collaboratorandonboard_keeps_token = true.Refs #496, #520