Skip to content

ci(triage): only a listed signer releases the spec gate; a push clears the sign-off - #524

Open
nadernik wants to merge 1 commit into
devfrom
ci/spec-signoff-by-owner
Open

nadernik wants to merge 1 commit into
devfrom
ci/spec-signoff-by-owner

Conversation

@nadernik

Copy link
Copy Markdown
Collaborator

Implements #513 decision 4: make the spec check required, and make nadernik code owner of supabase/migrations/ and supabase/functions/.

Why the gate needed a change first. triage/spec-gate passed whenever the spec-signoff label was present. Anyone with triage rights can add a label, so the author could add it to their own PR. A sign-off also kept covering every push made after it. Requiring the check as it stood would have changed nothing.

What changes:

  • triage.yml: the gate passes only when the most recent spec-signoff label was added by a listed signer (SIGNERS = ['nadernik']). A push after the sign-off removes the label, so the gate holds until someone signs again, like a stale review.
  • CODEOWNERS: adds /supabase/migrations/, /supabase/functions/ and /.github/workflows/triage.yml.
  • tests/guards/spec-gate-signoff.test.mjs: runs the gate's own script from triage.yml against a fake GitHub client. On the previous script it fails 3 of 5 tests: a non-signer's label, a non-signer re-adding the label, and a push after sign-off. All 106 guards pass locally.

After merge, still to do (repository settings, not in this diff):

  1. Add triage/spec-gate to the required checks in the dev ruleset.
  2. Re-run the gate on open Class-C PRs, so the new rule replaces their existing statuses.

Refs #513

…s the sign-off

The gate read 'is the spec-signoff label present', and anyone with triage rights can add a label,
so an author could release the gate on their own PR, and one sign-off kept covering every later
push. The gate now asks who added the label, and a push after the sign-off removes it.

CODEOWNERS adds supabase/migrations/, supabase/functions/ and triage.yml (#513 decision 4).
tests/guards/spec-gate-signoff runs the gate's own script against a fake client; it fails 3 of 5
on the previous script.

Refs #513
@github-actions github-actions Bot added the spec:C Danger layer — Spec Kit + sign-off required label Nov 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🤖 Triage: Class C → spec:C

Touches a danger layer. Requires Spec Kit artifacts (spec/plan/tasks/qa-itinerary), a Constitution Check, and human sign-off. Never auto-merges.

Blast radius: HIGH

  • ci-workflow: CI/CD workflow — this is the pipeline that ships everything else, including this gate.
  • triage-gate: The gate itself (classifier or guard suite). A change that could weaken the gate must never pass through the gate automatically.

Complexity: HIGH

  • 117 lines changed (> 80).

Files that set the class:

  • .github/workflows/triage.yml → ci-workflow (hard)
  • tests/guards/spec-gate-signoff.test.mjs → triage-gate (hard)

Deterministic classifier — computed from the diff, not from the issue text. Change the rules in scripts/triage/classify.mjs (itself a Class-C path).

@github-actions

Copy link
Copy Markdown
Contributor

🛑 Class C — this touches a danger layer

Per the constitution (Development Workflow) danger-layer changes are spec-driven. Before this can merge, a maintainer must:

  1. Create the Spec Kit artifacts in bbqs-agent/specs/<NNN-feature>/ — spec.md, plan.md (with a Constitution Check), tasks.md, qa-itinerary.md.
  2. Point bbqs-agent/.specify/feature.json at that directory.
  3. Run the Find → Fix → Test → Verify-Live loop, incl. the sandbox QA workflow.
  4. A signer (nadernik) adds the spec-signoff label to release the triage/spec-gate check. A push after that removes it.

This gate is here because a small-looking diff to .github/workflows/triage.yml reaches far beyond the file it edits.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

spec:C Danger layer — Spec Kit + sign-off required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant