Repository navigation
Conversation
…s the sign-off The gate read 'is the spec-signoff label present', and anyone with triage rights can add a label, so an author could release the gate on their own PR, and one sign-off kept covering every later push. The gate now asks who added the label, and a push after the sign-off removes it. CODEOWNERS adds supabase/migrations/, supabase/functions/ and triage.yml (#513 decision 4). tests/guards/spec-gate-signoff runs the gate's own script against a fake client; it fails 3 of 5 on the previous script. Refs #513
Contributor
🤖 Triage: Class C →
|
Contributor
🛑 Class C — this touches a danger layerPer the constitution (Development Workflow) danger-layer changes are spec-driven. Before this can merge, a maintainer must:
This gate is here because a small-looking diff to |
This was referenced Nov 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #513 decision 4: make the spec check required, and make nadernik code owner of
supabase/migrations/andsupabase/functions/.Why the gate needed a change first.
triage/spec-gatepassed whenever thespec-signofflabel was present. Anyone with triage rights can add a label, so the author could add it to their own PR. A sign-off also kept covering every push made after it. Requiring the check as it stood would have changed nothing.What changes:
triage.yml: the gate passes only when the most recentspec-signofflabel was added by a listed signer (SIGNERS = ['nadernik']). A push after the sign-off removes the label, so the gate holds until someone signs again, like a stale review.CODEOWNERS: adds/supabase/migrations/,/supabase/functions/and/.github/workflows/triage.yml.tests/guards/spec-gate-signoff.test.mjs: runs the gate's own script fromtriage.ymlagainst a fake GitHub client. On the previous script it fails 3 of 5 tests: a non-signer's label, a non-signer re-adding the label, and a push after sign-off. All 106 guards pass locally.After merge, still to do (repository settings, not in this diff):
triage/spec-gateto the required checks in thedevruleset.Refs #513