Fix current datetime propagation#1120
Merged
Merged
Conversation
Closes bradygaster#1119 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Squad’s coordinator and Scribe templates to propagate a resolved current datetime value instead of unresolved placeholders, and adds regression coverage for that contract.
Changes:
- Adds CI coverage for datetime placeholder regressions in canonical templates.
- Updates coordinator spawn examples to pass a resolved
CURRENT_DATETIMEliteral. - Syncs Scribe datetime examples and mirrored template copies across CLI/SDK/root/GitHub agent locations.
Show a summary per file
| File | Description |
|---|---|
| test/ci/datetime-template.test.ts | Adds regression checks for datetime propagation and placeholder usage. |
| .squad-templates/squad.agent.md | Updates canonical coordinator datetime resolution and spawn prompt guidance. |
| .squad-templates/scribe-charter.md | Updates canonical Scribe datetime examples. |
| templates/squad.agent.md.template | Mirrors coordinator template updates. |
| templates/scribe-charter.md | Mirrors Scribe charter updates. |
| packages/squad-cli/templates/squad.agent.md.template | Mirrors coordinator template updates for CLI package. |
| packages/squad-cli/templates/scribe-charter.md | Mirrors Scribe charter updates for CLI package. |
| packages/squad-sdk/templates/squad.agent.md.template | Mirrors coordinator template updates for SDK package. |
| packages/squad-sdk/templates/scribe-charter.md | Mirrors Scribe charter updates for SDK package. |
| .github/agents/squad.agent.md | Syncs GitHub agent copy with canonical coordinator template. |
| .changeset/fix-current-datetime-propagation.md | Adds patch changeset for CLI and SDK packages. |
Copilot's findings
- Files reviewed: 11/11 changed files
- Comments generated: 5
Closes bradygaster#1119 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
All review feedback from copilot-pull-request-reviewer has been addressed and CI is now passing. Ready for review — all 5 threads resolved, all checks green ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates the Squad coordinator and Scribe templates so spawned agents receive a resolved
CURRENT_DATETIMEvalue instead of unresolved placeholder text. Adds regression coverage and a patch changeset for the template behavior.Why
Clean/new Squad sessions could carry
{current_datetime}through spawn examples, leaving agents to infer or write the wrong day/time.Fixes: #1119
How
The coordinator now resolves
CURRENT_DATETIMEonce from<current_datetime>, sanity-checks it, and falls back to a local date command if the system value is missing or implausible. Date-bearing agent and Scribe examples now explicitly require substituting the literal received timestamp, and synced template mirrors keep init/upgrade output aligned.npx changeset add/.changeset/*.md, directCHANGELOG.mdentry for maintainers, orskip-changeloglabel for no user-facing changes)PR Readiness Checklist
Branch & Commit
dev(notmain)dev(git fetch upstream && git rebase upstream/dev)git diff --cached --stat)Build & Test
npm run buildpassesnpm testpasses (all tests green)npm run lintpasses (type check clean)npm run lint:eslintpassesChangeset
npx changeset add(ifpackages/squad-sdk/src/orpackages/squad-cli/src/changed)CHANGELOG.mdentry (maintainers only — write-protected for external contributors)skip-changeloglabel applied (if no user-facing changes)Docs
N/A - this fixes generated coordinator/Scribe template behavior, not a new feature or docs page.
Exports
N/A - no SDK module exports changed.
Breaking Changes
None.
Waivers
N/A.