chore(deps): drop redundant deps, stop committing tarballs, cache docs CI#1110
Conversation
There was a problem hiding this comment.
Pull request overview
This PR is described as dependency/repository cleanup, but the actual diff also adds substantial CI automation, new CLI functionality, docs/templates, tests, and release/versioning changes across the repo.
Changes:
- Removes/updates dependency declarations, package versions, lockfile entries, changesets, tarball tracking, and changelog content.
- Adds repo-health, readiness, impact, nudge, scope, docs-link, bootstrap/security/architecture scripts and workflows.
- Adds/updates product code, docs, templates, tests, and a new
squad skillcommand/APM integration.
Show a summary per file
| File | Description |
|---|---|
.gitignore |
Ignores package tarballs. |
.github/copilot-instructions.md |
Documents PR nudge automation. |
.github/workflows/squad-ci.yml |
Switches docs quality install path to cached npm install/ci flow. |
.github/workflows/squad-docs-links.yml |
Adds docs link-check workflow. |
.github/workflows/squad-impact.yml |
Adds PR impact analysis workflow. |
.github/workflows/squad-npm-publish.yml |
Adjusts lockfile integrity check. |
.github/workflows/squad-pr-nudge.yml |
Adds stale PR nudge workflow. |
.github/workflows/squad-pr-readiness.yml |
Adds PR readiness workflow. |
.github/workflows/squad-repo-health.yml |
Adds repo-health review workflow. |
.github/workflows/squad-scope-check.yml |
Adds repo-health scope guard. |
.squad-templates/squad.agent.md |
Updates coordinator template behavior and references. |
.squad-templates/workflow-wiring-appendix-a-code-reviewer.md |
Adds workflow wiring appendix. |
.squad-templates/workflow-wiring-appendix-b-documenter.md |
Adds workflow wiring appendix. |
.squad-templates/workflow-wiring-guide.md |
Adds workflow wiring guide. |
.squad/skills/fact-checking/SKILL.md |
Adds fact-checking skill. |
.squad/templates/agents/challenger.md |
Adds Challenger agent template. |
.changeset/* |
Deletes many consumed changesets and adds new release notes. |
CHANGELOG.md |
Adds 0.9.4 changelog heading. |
docs/src/content/docs/features/state-backends.md |
Adds state backend documentation. |
docs/src/content/docs/reference/sdk.md |
Updates API reference link. |
docs/src/navigation.ts |
Updates SDK API Reference slug. |
index.cjs |
Renames import force flag variable. |
package.json |
Bumps version and removes root Playwright dev dependency. |
package-lock.json |
Updates versions/dependency lock entries. |
packages/squad-cli/package.json |
Bumps version, pins SDK dependency, removes esbuild dev dependency. |
packages/squad-cli/src/cli-entry.ts |
Registers new skill command. |
packages/squad-cli/src/cli/commands/skill.ts |
Adds APM skill publish/install/list command. |
packages/squad-cli/src/cli/commands/watch/agent-spawn.ts |
Adds shared watch agent-spawn helper. |
packages/squad-sdk/package.json |
Bumps SDK version. |
packages/squad-sdk/src/platform/detect.ts |
Allows dots in GitHub/Azure repo parsing. |
scripts/analyze-impact.mjs |
Adds PR impact analysis script. |
scripts/architectural-review.mjs |
Adds architectural review script. |
scripts/check-bootstrap-deps.mjs |
Adds bootstrap dependency guard. |
scripts/check-squad-leakage.mjs |
Adds .squad/ leakage detector. |
scripts/impact-utils/parse-diff.mjs |
Adds diff parsing helpers. |
scripts/impact-utils/report-generator.mjs |
Adds impact report generator. |
scripts/impact-utils/risk-scorer.mjs |
Adds impact risk scoring. |
scripts/pr-readiness.mjs |
Adds PR readiness checks/comment orchestration. |
scripts/repo-health-comment.mjs |
Adds shared repo-health PR comment utility. |
scripts/security-review.mjs |
Adds security review script. |
test/cli/init.test.ts |
Moves temp test root to OS temp directory. |
test/cli/loop.test.ts |
Updates expected CLI error text. |
test/cli/upgrade.test.ts |
Moves temp root and removes customization-warning tests. |
test/comms-teams-integration.test.ts |
Updates expected token refresh warning. |
test/cross-package-exports.test.ts |
Adds SDK export smoke tests. |
test/migrate-directory.test.cjs |
Updates .NET workflow tests to use upgrade. |
test/platform-adapter.test.ts |
Adds dotted repo-name parser coverage. |
test/scripts/parse-diff.test.ts |
Adds diff parsing tests. |
test/scripts/risk-scorer.test.ts |
Adds risk scorer tests. |
test/scripts/security-review-skills.test.ts |
Deletes skill security scanner tests. |
test/scripts/security-review.test.ts |
Removes skill scanner categories from expected set. |
test/template-sync.test.ts |
Runs template sync before template comparisons. |
packages/squad-cli/bradygaster-squad-cli-0.8.25-build.10.tgz |
Deletes committed tarball. |
packages/squad-sdk/bradygaster-squad-sdk-0.8.25-build.10.tgz |
Deletes committed tarball. |
Copilot's findings
Comments suppressed due to low confidence (1)
.squad-templates/squad.agent.md:918
- This points coordinators at
.squad/templates/workflow-wiring-guide.md, but this PR only adds the guide under.squad-templates/; the current.squad/templates/tree does not contain it. Until the file is installed/copied into the path referenced here, agents following this instruction will hit a missing-file path.
7. **Wire enforcement (if applicable).** If the new member's role involves gating other agents' work (reviewer, design approver, quality gate), add a numbered enforcement rule to `routing.md` → Rules section. A routing table entry (step 6) only handles explicit requests — enforcement rules are required for automatic gates. Read `.squad/templates/workflow-wiring-guide.md` for the full wiring process, including walkthroughs for common role types (code reviewer, documenter). Check `.squad/templates/issue-lifecycle.md` for lifecycle integration if the project uses PR-gated workflows.
- Files reviewed: 68/72 changed files
- Comments generated: 24
PR Checkup — feedback triagedStatus: 12 of 24 threads resolved (out-of-scope/script-and-workflow bugs to be addressed in a focused repo-health PR + rebase). 12 threads left open intentionally — they require author judgment:
Root cause: PR was branched from stale Recommended next step: restructure into focused PRs (dep cleanup, @copilot-pull-request-reviewer — kept all design questions open for author decision; thanks for the careful review. |
cd0b300 to
9a6b503
Compare
…s CI - Remove redundant 'playwright' devDep (already provided by '@playwright/test') - Remove unused 'esbuild' devDep from squad-cli (build script uses tsc only; source-level mentions in build/bundle.ts and build/ci-pipeline.ts are config templates, not runtime invocations) - Delete stale pre-built tarballs (packages/*/bradygaster-*-0.8.25-build.10.tgz); add 'packages/**/*.tgz' to .gitignore so they don't return - Switch '.github/workflows/squad-ci.yml' docs-quality job from uncached 'npm install --no-save' to cached 'npm ci' (markdownlint-cli2 and cspell are already in root devDependencies) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
9a6b503 to
0f428d8
Compare
|
✅ All previously-flagged review feedback has been addressed:
@copilot-pull-request-reviewer — ready for another look when you get a chance. Thanks! |
Summary
Three low-risk dependency cleanups bundled into one zero-behavior-change chore PR:
playwrightfrom rootdevDependencies(kept@playwright/test, which already bundles the runner — declaring both forces npm to resolve the bare package as a duplicate install path).esbuildfrompackages/squad-cli/devDependencies. The CLI build script (tsc -p tsconfig.json && cpSync(src/remote-ui, dist/remote-ui)) does not invoke esbuild. The two source-level mentions (packages/squad-sdk/src/build/bundle.ts,packages/squad-sdk/src/build/ci-pipeline.ts) are configuration templates that emitnpx esbuild ...strings for downstream consumers — they do not import the package.packages/squad-cli/bradygaster-squad-cli-0.8.25-build.10.tgz,packages/squad-sdk/bradygaster-squad-sdk-0.8.25-build.10.tgz— ~840 KB combined and stale: the project is at 0.9.4). Addpackages/**/*.tgzto.gitignoreso they cannot return. Future insider tarballs should be published to GitHub Releases / npm, not committed.docs-qualityjob in.github/workflows/squad-ci.ymlfrom uncachednpm install --no-save markdownlint-cli2 cspellto cachednpm ci. Both tools are already declared in rootdevDependencies, so the separate install was redundant.What Changed
package.json: removed"playwright": "^1.58.2".packages/squad-cli/package.json: removed"esbuild": "^0.25.0".package-lock.json: regenerated to drop the direct devDep entries (transitive mentions ofplaywright/esbuildremain — they are pulled in by other packages and are unaffected)..gitignore: appendedpackages/**/*.tgz.packages/squad-cli/bradygaster-squad-cli-0.8.25-build.10.tgzandpackages/squad-sdk/bradygaster-squad-sdk-0.8.25-build.10.tgz..github/workflows/squad-ci.yml:docs-qualityjob nowsetup-nodewithcache: 'npm',npm ciinstead ofnpm install --no-save.Testing
npm run lintclean.npm run buildsucceeds for both packages withoutesbuildavailable.npm packon each workspace still produces a tarball (now in.gitignore'd location).Notes
This PR is part of a small five-PR series capturing low-risk performance improvements found while reviewing the repo against the current
main. The PRs are designed to land independently; this one has no code/behavior changes so it is the safest to merge first.Companion PRs: