Added trim on prompt and some code comments for beginners/students - #3
Open
abhiram11 wants to merge 2 commits into
Open
Added trim on prompt and some code comments for beginners/students#3abhiram11 wants to merge 2 commits into
abhiram11 wants to merge 2 commits into
Conversation
added 2 commits
December 9, 2022 03:33
…s provided random logos as Brad said at end of his vid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added trim for the prompt, blank strings provided random logos as Brad said at end of his video.
I also added some comments for learners to remember important points that Brad mentioned and also some explanations that he probably skimmed.
I also added (optional, commented in index.html) size selector to give a clearer understanding of the size field.
P.S. I'm just beginning to Open Source.
Here's a snippet that's seen if the prompt is just empty spaces e.g., " ":