chore: bump update#85
Draft
bradtaniguchi wants to merge 5 commits into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the development Node.js version reference and refreshes the dependency lockfile as part of an npm audit/dependency update pass.
Changes:
- Bumped
.nvmrcfrom Nodev20.18.1tov24.16.0. - Updated
package-lock.jsonwith newer resolved versions for multiple transitive dependencies (notably Babel-related packages, AJV, js-yaml, qs, etc.).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.nvmrc |
Updates the default local Node version used by nvm. |
package-lock.json |
Refreshes locked dependency graph/versions after audit/update. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Added project references structure to separate build targets: - tsconfig.base.json: base compiler options for production - tsconfig.main.json: production build (extends base) - tsconfig.spec.json: test setup with jest types - tsconfig.typedoc.json: documentation generation config - typedoc.json: typedoc output configuration and options Fixed package.json build:docs script to use typedoc options file
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 10 changed files in this pull request and generated 6 comments.
Comments suppressed due to low confidence (1)
package.json:12
npm run build/npm run devinvoketscagainst the roottsconfig.json, but that config now hasfiles: []and onlyreferences. With the current scripts (no-b),tscwill not build the referenced projects and may fail with “no inputs were found”, breaking CI (on-pushrunsnpm run build). Update scripts to build the referenced projects (e.g., usetsc -b/tsc -b --watchor point-pattsconfig.main.json).
"scripts": {
"prepare": "husky install",
"build": "tsc",
"dev": "tsc --watch",
"lint": "eslint",
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "extends": "./tsconfig.base.json" | |||
Comment on lines
+8
to
+10
| "skipLibCheck": true | ||
| }, | ||
| "types": ["node"], |
Comment on lines
+9
to
+11
| "noEmit": true | ||
| }, | ||
| "types": ["node"], |
Comment on lines
16
to
19
| "clean": "rimraf lib docs", | ||
| "build:docs": "npx typedoc src", | ||
| "build:docs": "npx typedoc --options typedoc.json", | ||
| "dev:docs": "npx typedoc src --watch && npx http-server docs", | ||
| "smoke:docs": "npx http-server docs" |
Comment on lines
14
to
17
| strategy: | ||
| matrix: | ||
| node: [18, 20, 22] | ||
| node: [22, 24] | ||
|
|
Comment on lines
+1
to
+3
| { | ||
| "entryPoints": ["src"], | ||
| "exclude": [ |
- Move 'types' into compilerOptions in tsconfig.base.json and tsconfig.typedoc.json - Add composite:true to tsconfig.main.json for project references support - Fix tsconfig.spec.json to extend tsconfig.base.json with proper includes/excludes - Remove tsconfig.spec.json from root references (test-only config) - Update build/dev scripts to use tsc -b for project references - Split dev:docs into watch and serve scripts; align with build:docs options file - Update actions/setup-node from v1 to v4 for reliable Node 24 support - Configure jest to explicitly use tsconfig.spec.json
Comment on lines
+3
to
+10
| "target": "es5", | ||
| "module": "commonjs", | ||
| "declaration": true, | ||
| "outDir": "./lib", | ||
| "strict": true, | ||
| "skipLibCheck": true, | ||
| "noEmit": true, | ||
| "types": ["node"] |
| @@ -10,7 +10,7 @@ jobs: | |||
|
|
|||
| - uses: actions/setup-node@v3 | |||
Comment on lines
+4
to
+5
| "*.spec.ts", | ||
| "*.test.ts" |
bradtaniguchi
marked this pull request as draft
June 2, 2026 04:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
chore: bump nvmrc
.nvmrcfrom Nodev20.18.1tov24.16.0(local dev version)enginesto>=22.0.0fix: ran npm audit
package-lock.jsonwith updated transitive dependency versions (Babel, AJV, js-yaml, qs, etc.)chore: TypeDoc configuration
typedoc.jsonoptions file for consistent doc generationtsconfig.typedoc.jsonfor TypeDoc-specific compiler settingsbuild:docsscript to use--options typedoc.jsondev:docsintodev:docs(watch) anddev:docs:serve(serve) to fix&&sequencing issuechore: TypeScript project references restructure
tsconfig.jsonto use project references (files: []+references)tsconfig.base.jsonfor shared compiler optionstsconfig.main.jsonas composite project for source buildstsconfig.spec.jsonto extendtsconfig.base.jsonwith proper spec-file includestypesintocompilerOptionsin all tsconfig files (was incorrectly at top-level)tsc -b/tsc -b --watchfor project referencesjest.config.jsto explicitly referencetsconfig.spec.jsonfix: CI workflow
actions/setup-nodefromv1tov4for reliable Node 24 installation