Repository navigation
fix: parse UPLOAD_SAVE_EXTENSIONS from the environment - #2
Merged
Merged
Conversation
pydantic-settings JSON-decodes list fields read from the environment before field validators run, so UPLOAD_SAVE_EXTENSIONS=.pdf,.png made the bot fail at startup with 'error parsing value'. Mark the field NoDecode and accept both a comma list and a JSON list; add tests that go through the environment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #1,
UPLOAD_SAVE_EXTENSIONS=.pdf,.png,.jpg,.cifin.envmade the bot exit at startup:error parsing value for field "upload_save_extensions" from source "EnvSettingsSource". pydantic-settings JSON-decodes list fields from the environment before field validators run; the tests in #1 passed the value as a Python argument, so they never hit that path.NoDecode, and accept both a comma list and a JSON list.Workaround until merged: write the value as a JSON list, e.g.
UPLOAD_SAVE_EXTENSIONS=[".pdf",".png"](now set in our.env).🤖 Generated with Claude Code