Skip to content

fix: parse UPLOAD_SAVE_EXTENSIONS from the environment - #2

Merged
burakbudanur merged 1 commit into
mainfrom
fix/upload-extensions-env-parsing
Nov 2, 2026
Merged

burakbudanur merged 1 commit into
mainfrom
fix/upload-extensions-env-parsing

Conversation

@burakbudanur

Copy link
Copy Markdown

After #1, UPLOAD_SAVE_EXTENSIONS=.pdf,.png,.jpg,.cif in .env made the bot exit at startup: error parsing value for field "upload_save_extensions" from source "EnvSettingsSource". pydantic-settings JSON-decodes list fields from the environment before field validators run; the tests in #1 passed the value as a Python argument, so they never hit that path.

  • Mark the field NoDecode, and accept both a comma list and a JSON list.
  • New tests set the variable through the environment (4 cases).
  • Full suite: 709 passed (excluding the MCP server test that needs an optional dependency); flake8 clean.

Workaround until merged: write the value as a JSON list, e.g. UPLOAD_SAVE_EXTENSIONS=[".pdf",".png"] (now set in our .env).

🤖 Generated with Claude Code

pydantic-settings JSON-decodes list fields read from the environment before field validators run, so UPLOAD_SAVE_EXTENSIONS=.pdf,.png made the bot fail at startup with 'error parsing value'. Mark the field NoDecode and accept both a comma list and a JSON list; add tests that go through the environment.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@burakbudanur
burakbudanur merged commit 877b5e0 into main Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant