[ashwkun]

Summary

• Feedback no longer leaves an empty strip above the navigation bar while something is playing. Feedback keeps the player in its small form beside the Floating bar, but every pane still reserved room for the full mini player, which hid the "How we handle feedback" link and pushed the list's buttons up.
• Splits the compose fields out of FeedbackComposeScreen to bring its cognitive complexity under Sonar's limit.

Motivation

• On a phone with an episode loaded, the bottom of Share your thoughts was cut off behind an empty band.

What changed

• feedbackBottomSpace / feedbackChromePadding (:feature:settings): each Feedback pane (form, conversation, sent screen, list buttons) subtracts the space the compact player frees as it docks (appBottomChromeOverlayOffset), never below what the navigation bar alone needs. Measured in layout, like Lore's clearance, so the docking animation doesn't recompose the page. Classic navigation and tablets keep the full clearance; the list's tail padding stays fixed.
• ComposeFields holds the form fields; behaviour unchanged.
• feature/settings/README.md updated.

Behavior & compatibility

• Before: an empty band about 80dp tall above the navigation bar on every Feedback pane while an episode was loaded. After: content runs down to the navigation bar.
• No API or payload changes.

Impact (required)

• user-impact-critical

• user-impact-high

• user-impact-medium

• user-impact-low

• no-user-impact

• backend-change

Release copy (verbatim)

CHANGELOG.md (required developer copy)

Fixed

• Feedback panes give back the room the docked compact player frees above the Floating navigation bar (feedbackBottomSpace), so the privacy link and list buttons are no longer cut off or pushed up; FeedbackComposeScreen split for Sonar's complexity limit.

Listener notes (required for user-impact changes)

• Listener notes already cover this change

Test plan

• :feature:settings:testDebugUnitTest (new FeedbackLayoutPolicyTest case: docked, not docked yet, nothing playing, Classic, rail; adaptive resize tests unchanged and passing) and detekt
• Built and installed on a phone; with an episode loaded the whole form, including the privacy link, shows above the navigation bar
• Required checks are green before merge, or a maintainer explicitly authorized a check bypass for this PR

Notes (optional)

• Adaptive states: tablets and the navigation rail keep their docked-player clearance (unchanged); phone portrait checked on a device; resize behaviour covered by the existing JVM transition tests.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud