docs: Adjust README.md#1508
Merged
Merged
Conversation
Pull Request Test Coverage Report for Build #5220Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build #5219Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build #5247Details
💛 - Coveralls |
Pask423
requested changes
Oct 20, 2025
| about: Before creating an issue, I have checked that the SDK documentation doesn't solve my issue. | ||
| - name: API documentation | ||
| url: https://developer.box.com/docs | ||
| url: https://developer.box.com/guides/ |
arjankowski
reviewed
Oct 20, 2025
|
|
||
| To generate a Json Web Signature used for retrieving tokens in the JWT authentication method, the Box Java SDK decrypts an encrypted private key. | ||
| For this purpose, Box Java SDK uses libraries (`org.bouncycastle:bcpkix-jdk18on:1.77` and `org.bouncycastle:bcprov-jdk18on:1.77`) | ||
| For this purpose, Box Java SDK uses libraries (`org.bouncycastle:bcpkix-jdk18on:1.82` and `org.bouncycastle:bcprov-jdk18on:1.82`) |
Contributor
There was a problem hiding this comment.
Do we use the same 1.82 version in two packages?
Contributor
Author
There was a problem hiding this comment.
Actually it is impossible to use two different versions in both packages
| Reader reader = new FileReader(JWT_CONFIG_PATH); | ||
| BoxConfig boxConfig = BoxConfig.readFrom(reader); | ||
| boxConfig.setPrivateKeyDecryptor(customDecryptor) | ||
| boxConfig.setPrivateKeyDecryptor(customDecryptor); |
Contributor
There was a problem hiding this comment.
Are you showing an example to the legacy package? Is so shouldn't we mention that this is only for com.box.sdk?
Is it possible to provide own implementation also for gen version of sdk?
Contributor
Author
There was a problem hiding this comment.
You're right. I'll add it
arjankowski
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.