Skip to content

fix(boxsdkgen): Use FolderFull in Item (box/box-codegen#860) #1501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukaszsocha2 merged 3 commits into from
Oct 15, 2025
Merged

fix(boxsdkgen): Use FolderFull in Item (box/box-codegen#860) #1501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42efa0d
chore: Update `.codegen.json` with commit hash of `codegen` and `open…
box-sdk-build Oct 10, 2025
a5bbd58
Merge remote-tracking branch 'origin/combined-sdk' into codegen-1031-…
Oct 14, 2025
48a01ca
feat: Use files from static_files_v10_overrides when combined flag is…
box-sdk-build Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .codegen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "engineHash": "733e376", "specHash": "fa34496", "version": "0.1.0" }
{ "engineHash": "48e5311", "specHash": "fa34496", "version": "0.1.0" }
24 changes: 12 additions & 12 deletions src/main/java/com/box/sdkgen/schemas/item/Item.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import com.box.sdkgen.internal.OneOfThree;
import com.box.sdkgen.schemas.filefull.FileFull;
import com.box.sdkgen.schemas.foldermini.FolderMini;
import com.box.sdkgen.schemas.folderfull.FolderFull;
import com.box.sdkgen.schemas.weblink.WebLink;
import com.box.sdkgen.serialization.json.EnumWrapper;
import com.box.sdkgen.serialization.json.JsonManager;
Expand All @@ -17,7 +17,7 @@

@JsonDeserialize(using = Item.ItemDeserializer.class)
@JsonSerialize(using = OneOfThree.OneOfThreeSerializer.class)
public class Item extends OneOfThree<FileFull, FolderMini, WebLink> {
public class Item extends OneOfThree<FileFull, FolderFull, WebLink> {

protected final String sequenceId;

Expand All @@ -38,13 +38,13 @@ public Item(FileFull fileFull) {
this.type = EnumWrapper.convertToString(fileFull.getType());
}

public Item(FolderMini folderMini) {
super(null, folderMini, null);
this.sequenceId = folderMini.getSequenceId();
this.name = folderMini.getName();
this.id = folderMini.getId();
this.etag = folderMini.getEtag();
this.type = EnumWrapper.convertToString(folderMini.getType());
public Item(FolderFull folderFull) {
super(null, folderFull, null);
this.sequenceId = folderFull.getSequenceId();
this.name = folderFull.getName();
this.id = folderFull.getId();
this.etag = folderFull.getEtag();
this.type = EnumWrapper.convertToString(folderFull.getType());
}

public Item(WebLink webLink) {
Expand All @@ -64,11 +64,11 @@ public FileFull getFileFull() {
return value0;
}

public boolean isFolderMini() {
public boolean isFolderFull() {
return value1 != null;
}

public FolderMini getFolderMini() {
public FolderFull getFolderFull() {
return value1;
}

Expand Down Expand Up @@ -115,7 +115,7 @@ public Item deserialize(JsonParser jp, DeserializationContext ctxt) throws IOExc
case "file":
return new Item(JsonManager.deserialize(node, FileFull.class));
case "folder":
return new Item(JsonManager.deserialize(node, FolderMini.class));
return new Item(JsonManager.deserialize(node, FolderFull.class));
case "web_link":
return new Item(JsonManager.deserialize(node, WebLink.class));
}
Expand Down
Loading