Parallelize MatchRunner#6
Open
stephenbush-wf wants to merge 5 commits into
Open
Conversation
…because we have a dedicated config file now, so we shouldnt need to clean it
Owner
|
Looks good! I'll give it some testing tonight/tomorrow. Glad that we are no longer messing up bc.conf |
Author
|
Me too!! I had to manually back it up and put it back whenever i used archon :) Only problem i'm seeing now is a big list of config files left around. Might need to add something to delete the files created by the runner before the thread exits. Though there's no guarantee it would run if the user cancels archon early, and the files would be left anyway.... Idk. |
|
Will this be merged in? And, on that note, is there intention to maintain this repo for battlecode2017? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bovard Code Review
Problem
Summary
There were problems when trying to parallelize matches because each match was reading/writing from the same config file which is re-written for each game, so:
Areas of Impact
Solution
Each thread now runs with its own dedicated config file which (should) remain undisturbed until the match is run, completed and reported, and then it runs the next game with that file.
Also provided a dedicated default config file (no longer
bc.conf) so that players are free to manipulate their own default settings without archon changing/overwriting them. Consequently, I also removed the config cleaner, because archon has a dedicated config file now that shouldn't need to be cleaned.How to QA/+10