Closed
Conversation
ZedThree
approved these changes
Nov 28, 2025
Member
ZedThree
left a comment
ZedThree
left a comment
There was a problem hiding this comment.
I'm not convinced of the wisdom of changing file_cache_maxsize like this, but I don't know the ins and outs of it. This change seems reasonable though
Contributor
|
This should be fixed in a different way by #336 because that PR removes the need to open many files at once. Large numbers of files being opened should now be unusual and warning is probably best. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it is best to completely remove the warning.
As a user I do not want to first figure out how many files I will be opening, and then set that with xarray to avoid a warning.
It was broken anyway, as it did always raise the warning, so I think it is best to remove the warning completely.
The first commit a4c0996 is still needed, as otherwise we may lower the limit, which is needed for other things.