Merged
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #283 +/- ##
=======================================
Coverage 68.94% 68.95%
=======================================
Files 15 15
Lines 3214 3215 +1
Branches 792 792
=======================================
+ Hits 2216 2217 +1
Misses 734 734
Partials 264 264
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
johnomotani
approved these changes
Mar 16, 2023
Collaborator
johnomotani
left a comment
johnomotani
left a comment
There was a problem hiding this comment.
Thanks @mikekryjak!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be useful for xHermes to know the type of topology (e.g. connected double null). I was going to write something for this but @johnomotani pointed out that this functionality already exists in xBOUT here. If it's already in xBOUT then this should be the only place where the topology is worked out. This simple PR adds it to the dataset metadata.
Will leave it as a draft for now in case I think of any other useful related metadata to expose.Need it for the polygon plotter PR, so would be good to merge it as is.