deps: move brace-expansion to 5.0.9 (GHSA-rgw5-rvv9-x895) - #18
Merged
Conversation
osv-scan hard-fails on brace-expansion 5.0.8 (CVSS 7.5, fixed in 5.0.9), holding the merge gate repo-wide. The package is transitive — ts-morph@28 -> @ts-morph/common -> minimatch -> brace-expansion — and deno.json pins only ts-morph@^28, so this is a lockfile move rather than a manifest change. minimatch@10.2.6 declares brace-expansion ^5.0.8, which 5.0.9 satisfies, so nothing upstream constrains the bump. Re-resolving the lock moves exactly one entry and leaves every other resolved version untouched. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MiZu9croRHLwMawSyNK8Sk
bdelanghe
marked this pull request as ready for review
August 13, 2026 12:32
bdelanghe
added a commit
that referenced
this pull request
Aug 13, 2026
Build and upload the release binaries while the release is still a draft, then publish it, so the published release is never briefly visible without its assets attached. Closes #5. Also picks up main's move of brace-expansion to 5.0.9 (GHSA-rgw5-rvv9-x895, #18), which is what unblocked the osv-scan check on this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17.
Option 1 from the issue — the lockfile moved. No
osv-scanner.toml, and.github/workflows/deps.ymlis untouched.What moved
Exactly one entry in
deno.lock, one file, two lines:before:
brace-expansion@5.0.8→ after:brace-expansion@5.0.9The integrity hash matches the value published on the npm registry for 5.0.9.
Why no manifest change was needed
The package is transitive —
ts-morph@28→@ts-morph/common@0.29.0→minimatch@10.2.6→brace-expansion— anddeno.jsonpins onlyts-morph@^28, so there is no manifest edit to make.Nothing upstream constrained the bump:
minimatch@10.2.6declaresbrace-expansion: "^5.0.8", and 5.0.9 satisfies that range.brace-expansion@5.0.9requiresbalanced-match ^4.0.2, already satisfied by thebalanced-match@4.0.4in the lock. Sots-morph@28did not hold this back, and no direct dependency version changed.Re-resolving the lock left every other resolved version untouched — the diff against the previous lock is only the two lines above.
Verification
Full
ci.ymlequivalent, run locally on deno 2.9.5:deno task checkmod.ts,cli.tsdeno lintdeno fmt --checkdeno task testdeno task drift check --entry mod.ts --golden .drift/surface.json"ok": true,golden: 21 symbols; live: 21 symbolsnpx jsr publish --dry-runThe dogfood gate holds at 21/21 symbols, unchanged.
That the advisory no longer applies
Checked against OSV directly, per package version:
brace-expansion@5.0.8→GHSA-rgw5-rvv9-x895brace-expansion@5.0.9→ no vulnerabilitiesAnd re-run through osv-scanner 2.5.0 the way the lane does it —
deno.lockconverted to a CycloneDX SBOM, since osv-scanner has no nativedeno.lockextractor. Both the before and after locks were scanned with the identical harness, so the clean result is a comparison and not the scan vouching for itself:before (control) — reproduces the red exactly, exit 1:
after — exit 0:
All 11 npm packages in the lock are clean, not just
brace-expansion.Blast radius
This unblocks the merge gate repo-wide. It is currently holding #16 (
fix(release): attach the binaries before the release is published), which is otherwise green —deno,version / version-check,addand CodeQL all pass there, andosv / osv-scanis the only failing check.Worth noting for follow-up, not fixed here:
.github/dependabot.ymlruns thegithub-actionsecosystem only, so nothing sweeps the npm/JSR side automatically.deps.ymlrescans weekly (Tuesdays), so a future transitive advisory will surface the same way — red on a lane that nothing bumps.Generated by Claude Code