Fix AttributeError in fix_route53_ids when Route53 ID parameter is not a string#3739
Open
enlorik wants to merge 1 commit into
Open
Fix AttributeError in fix_route53_ids when Route53 ID parameter is not a string#3739enlorik wants to merge 1 commit into
enlorik wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#3033
Description of changes:
fix_route53_idscalls.split('/')on each matching Route53 resource ID parameter but does not guard against non-string values. PassingHostedZoneId=Nonetriggers this handler beforeParamValidatorruns and raises anAttributeErrorwith no useful context. Adding anisinstance(params[name], str)guard lets non-string values pass through to normal parameter validation, which produces a clearParamValidationError.generated by AI tools, reviewed by enlorik