reject trailing newline in host label validators#3724
Open
metsw24-max wants to merge 1 commit into
Open
Conversation
Author
|
gentle ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
botocore's host label validators all anchor with
$, which in Python also matches just before a trailing newline, so a value such asus-east-1\n,mybucket\nor adata\nhost prefix passes validation and the unchanged string is then used to build the request host.validate_region_nameeven documents that its argument must be a valid host label, yet it accepts the newline, and the same gap exists invalidate_bucket_name, theHeaderToHostHoisterhostname check, theS3ControlEndpointSetterhost label check and the serialiser host prefix check. The region case is the most exposed because that value can be sourced from an S3 cross-region redirect response and then feeds endpoint resolution and the SigV4 signing scope.is_valid_endpoint_urlalready screens for\t\r\nthroughUNSAFE_URL_CHARS, so these label validators are the remaining place a control character can slip past. I moved the trailing anchor to\Zin each one so a match has to reach the actual end of the string, and left the ARN and resource regexes alone since those re-extract a clean label and never carry a newline through. Valid regions, bucket names and host labels behave exactly as before.