Fix CloudFront signer wildcard question mark handling#3710
Open
rohan-patnaik wants to merge 1 commit into
Open
Fix CloudFront signer wildcard question mark handling#3710rohan-patnaik wants to merge 1 commit into
rohan-patnaik wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3377
Summary
This fixes CloudFront signed URL generation for resource URLs that use
?as a CloudFront wildcard instead of a query-string separator.Why
Before this change,
_build_url()checked only whether?existed anywhere in the URL. A resource likehttp://test.com/example_202?.zipwas treated as if it already had query parameters, so signing parameters were appended with&and produced an invalid URL.Test plan
.venv/bin/python -m pytest tests/unit/test_signers.py::TestCloudfrontSigner.venv/bin/python -m black --check botocore/signers.py tests/unit/test_signers.py