Skip to content

feat(agent-kiro-kit): fit the Kiro adapter to long Delivery stages - #28

Merged
botanarede merged 2 commits into
mainfrom
feat/story-7-2a-kiro-agent-adapter-fits-long-delivery-stages
Nov 9, 2026
Merged

botanarede merged 2 commits into
mainfrom
feat/story-7-2a-kiro-agent-adapter-fits-long-delivery-stages

Conversation

@botanarede

Copy link
Copy Markdown
Owner

Story 7.2a. Closes stdin, kills and reaps the CLI on timeout or step cancellation (reap bounded at 2 s so a child holding the pipes cannot stall a timed-out stage), documents the Delivery stage contract in the README and adds fake-CLI tests for argv, cwd, trust scope, timeout, non-zero exit and result shape. packages/beddel-py is unchanged. Kit tests: 58 passed; validate.py --schema: all 45 kits passed. Review: 2 rounds, final APPROVE.

Close stdin, kill and reap the CLI on timeout or step cancellation, document the Delivery stage contract and add fake-CLI tests for argv, cwd, trust scope, timeout and exit cases.
Process.wait only returns after the output pipes close, so a child of the CLI holding them kept a timed-out stage waiting. Bound the reap, cover it with a grandchild test and make the cancellation test deterministic.
@botanarede
botanarede merged commit 022b7ab into main Nov 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants