Repository navigation
feat(agent-kiro-kit): fit the Kiro adapter to long Delivery stages - #28
Merged
botanarede merged 2 commits intoNov 9, 2026
Merged
botanarede merged 2 commits into
botanarede merged 2 commits into
Conversation
Close stdin, kill and reap the CLI on timeout or step cancellation, document the Delivery stage contract and add fake-CLI tests for argv, cwd, trust scope, timeout and exit cases.
Process.wait only returns after the output pipes close, so a child of the CLI holding them kept a timed-out stage waiting. Bound the reap, cover it with a grandchild test and make the cancellation test deterministic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story 7.2a. Closes stdin, kills and reaps the CLI on timeout or step cancellation (reap bounded at 2 s so a child holding the pipes cannot stall a timed-out stage), documents the Delivery stage contract in the README and adds fake-CLI tests for argv, cwd, trust scope, timeout, non-zero exit and result shape. packages/beddel-py is unchanged. Kit tests: 58 passed; validate.py --schema: all 45 kits passed. Review: 2 rounds, final APPROVE.