Skip to content

fix(tools-git-kit): report a failed git fetch as a GitToolError - #26

Merged
botanarede merged 1 commit into
mainfrom
feat/story-7-0c-git-fetch-reports-a-failed-fetch
Nov 9, 2026
Merged

botanarede merged 1 commit into
mainfrom
feat/story-7-0c-git-fetch-reports-a-failed-fetch

Conversation

@botanarede

Copy link
Copy Markdown
Owner

Story 7.0c (TD-20). git_fetch discarded the exit code and returned a success dict for a failed fetch. A non-zero exit now raises the kit's existing GitToolError (exit status, argv-built command, git stderr). Success result, argv, cwd and 300 s timeout unchanged. Adds six regression tests that need no real remote. Gates: kit pytest 35 passed (29 baseline + 6), ruff/format/mypy identical to base, validate.py --schema 45 kits OK.

git_fetch discarded the exit code and returned a success dict for a failed
fetch (TD-20). A non-zero exit now raises the kit's existing GitToolError with
the exit status, the argv-built command and git's stderr. Success result, argv,
cwd and the 300 s timeout are unchanged. Adds six regression tests that need no
real remote.
@botanarede
botanarede merged commit 603e63d into main Nov 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants